From 9de6c8b5032fd71ae946283fd808fad70e6f278a Mon Sep 17 00:00:00 2001 From: William Robinet Date: Thu, 3 Sep 2020 19:09:04 +0200 Subject: [PATCH] Fix multiple segfault by OOB read because of wrong format string specifier --- ssl/ssl.enums.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ssl/ssl.enums.c b/ssl/ssl.enums.c index 592af15..ca1fab6 100644 --- a/ssl/ssl.enums.c +++ b/ssl/ssl.enums.c @@ -240,7 +240,7 @@ static int decode_HandshakeType_ClientHello(ssl,dir,seg,data) if (ssl_decode_switch(ssl,extension_decoder,ex,dir,seg,data) == R_NOT_FOUND) { decode_extension(ssl,dir,seg,data); P_(P_RH){ - explain(ssl, "Extension type: %s not yet implemented in ssldump", ex); + explain(ssl, "Extension type: %u not yet implemented in ssldump\n", ex); } continue; } @@ -300,7 +300,7 @@ static int decode_HandshakeType_ServerHello(ssl,dir,seg,data) if (ssl_decode_switch(ssl,extension_decoder,ex,dir,seg,data) == R_NOT_FOUND) { decode_extension(ssl,dir,seg,data); P_(P_RH){ - explain(ssl, "Extension type: %s not yet implemented in ssldump", ex); + explain(ssl, "Extension type: %u not yet implemented in ssldump,\n", ex); } continue; } @@ -2538,7 +2538,7 @@ static int decode_extension_server_name(ssl,dir,seg,data) if (ssl_decode_switch(ssl,server_name_type_decoder,t,dir,seg,data) == R_NOT_FOUND) { decode_server_name(ssl,dir,seg,data); P_(P_RH){ - explain(ssl, "Server Name type: %s not yet implemented in ssldump", t); + explain(ssl, "Server Name type: %u not yet implemented in ssldump\n", t); } continue; }