chg: [rssdir] Make rssdir work in the modern world - move to Python 3

bin/rssdir.py

@@ -5,9 +5,8 @@
 #
 # an example of use on the current directory :
 #
-# python2.5 /usr/local/bin/rssdir.py --prefix http://www.foo.be/cours/ . >rss.xml
+# python3 /usr/local/bin/rssdir.py --prefix http://www.foo.be/cours/ . >rss.xml
 #
-# Don't really need python2.5 except for ElementTree but you are free to install it.
 
 import os, fnmatch
 import time
@@ -15,11 +14,11 @@ import sys
 import xml.etree.ElementTree as ET
 from optparse import OptionParser
 
-version = "0.1"
+version = "0.2"
 
 # recursive list file function from the ASPN cookbook
-def all_files(root, patterns='*', single_level=False, yield_folders=False):
-        patterns = patterns.split(';')
+def all_files(root, patterns="*", single_level=False, yield_folders=False):
+    patterns = patterns.split(";")
     for path, subdirs, files in os.walk(root):
         if yield_folders:
             files.extend(subdirs)
@@ -32,6 +31,7 @@ def all_files(root, patterns='*', single_level=False, yield_folders=False):
         if single_level:
             break
 
+
 def date_files(filelist):
     date_filename_list = []
 
@@ -40,31 +40,35 @@ def date_files(filelist):
         last_update = stats[8]
         date_filename_tuple = last_update, filename
         date_filename_list.append(date_filename_tuple)
-
     return date_filename_list
 
+
 def date_as_rfc(value):
     return time.strftime("%a, %d %b %Y %H:%M:%S +0000", time.localtime(value))
 
 
-def build_rss(myitem,maxitem):
+def build_rss(myitem, maxitem):
 
-	RSSroot = ET.Element( 'rss', {'version':'2.0'} )
-	RSSchannel = ET.SubElement( RSSroot, 'channel' )
+    RSSroot = ET.Element("rss", {"version": "2.0"})
+    RSSchannel = ET.SubElement(RSSroot, "channel")
 
-	ET.SubElement( RSSchannel, 'title' ).text = 'RSS feed of ' + str(title)
-	ET.SubElement( RSSchannel, 'link' ).text = link
-	ET.SubElement( RSSchannel, 'description' ).text = 'A directory RSSified by rssdir.py ' + version
-	ET.SubElement( RSSchannel, 'generator' ).text = 'A directory RSSified by rssdir.py ' + version
-	ET.SubElement( RSSchannel, 'pubDate' ).text = date_as_rfc(time.time())
+    ET.SubElement(RSSchannel, "title").text = "RSS feed of " + str(title)
+    ET.SubElement(RSSchannel, "link").text = link
+    ET.SubElement(RSSchannel, "description").text = (
+        "A directory RSSified by rssdir.py " + version
+    )
+    ET.SubElement(RSSchannel, "generator").text = (
+        "A directory RSSified by rssdir.py " + version
+    )
+    ET.SubElement(RSSchannel, "pubDate").text = date_as_rfc(time.time())
 
     for bloodyitem in myitem[0:maxitem]:
 
-		RSSitem = ET.SubElement ( RSSchannel, 'item' )
-		ET.SubElement( RSSitem, 'title' ).text = bloodyitem[1]
-		ET.SubElement( RSSitem, 'pubDate' ).text = date_as_rfc(bloodyitem[0])
-		ET.SubElement( RSSitem, 'description').text = prefixurl+bloodyitem[1]
-		ET.SubElement( RSSitem, 'guid').text = prefixurl+bloodyitem[1]
+        RSSitem = ET.SubElement(RSSchannel, "item")
+        ET.SubElement(RSSitem, "title").text = bloodyitem[1]
+        ET.SubElement(RSSitem, "pubDate").text = date_as_rfc(bloodyitem[0])
+        ET.SubElement(RSSitem, "description").text = prefixurl + bloodyitem[1]
+        ET.SubElement(RSSitem, "guid").text = prefixurl + bloodyitem[1]
 
     RSSfeed = ET.ElementTree(RSSroot)
     feed = ET.tostring(RSSroot)
@@ -80,38 +84,68 @@ def complete_feed(myfeed):
 usage = "usage: %prog [options] directory"
 parser = OptionParser(usage)
 
-parser.add_option("-p","--prefix",dest="prefix",help="http prefix to be used for each entry, default none")
-parser.add_option("-t","--title",dest="title",help="set a title to the rss feed, default using prefix",type="string")
-parser.add_option("-l","--link",dest="link",help="http link set, default is prefix and none if prefix not set")
-parser.add_option("-m","--maxitem",dest="maxitem",help="maximum item to list in the feed, default 32",type="int")
+parser.add_option(
+    "-p",
+    "--prefix",
+    dest="prefix",
+    default="",
+    help="http prefix to be used for each entry, default none",
+)
+parser.add_option(
+    "-t",
+    "--title",
+    dest="title",
+    help="set a title to the rss feed, default using prefix",
+    type="string",
+)
+parser.add_option(
+    "-l",
+    "--link",
+    dest="link",
+    help="http link set, default is prefix and none if prefix not set",
+)
+parser.add_option(
+    "-m",
+    "--maxitem",
+    dest="maxitem",
+    help="maximum item to list in the feed, default 32",
+    default=32,
+    type="int",
+)
 
 (options, args) = parser.parse_args()
 
 if options.prefix is None:
-	prefixurl = ''
-else :
+    prefixurl = ""
+else:
     prefixurl = options.prefix
 
 if options.link is None:
     link = options.prefix
-else :
+else:
     link = options.link
 
 if options.title is None:
     title = options.prefix
-else :
+else:
     title = options.title
 
 if options.maxitem is None:
     maxitem = 32
-else :
+else:
     maxitem = options.maxitem
 
+if not args:
+    parser.print_help()
+    sys.exit(0)
 
-mylist = date_files(all_files(args[0]))
+file_to_list = []
+for x in all_files(args[0]):
+    file_to_list.append(x)
+
+mylist = date_files(file_to_list)
 
 mylist.sort()
 mylist.reverse()
 
-print complete_feed(build_rss(mylist,maxitem))
-
+print(complete_feed(build_rss(mylist, maxitem)))