adulau/art
1
0
Fork 0
mirror of https://github.com/adulau/art.git synced 2024-11-21 17:47:05 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix bug where some pages where not shown as tiles.

Browse source 
This commit refactors the `tiles.html` include file so that when the
`site.tiles-source` is pages, pages with `show_tile: false` set in their
Front Matter are not counted as having been shown. Prior to this commit,
such pages were iterated over in the `for` loop, consuming a loop
iteration from the `site.tiles-count` counter.

Put another way, say you have set `tiles-count` to 6, and you have a
total of 10 pages. Of these ten pages, six have `show_tile` set to
`false`. The natural expectation would be that the home page layout
would display four tiles (10 - 6 = 4), but in fact, the exact number of
page tiles shown would depend on the specific lexicographical ordering
of the `site.html_pages` array, which could result in fewer than four
page tiles being shown.

This commit fixes the issue by excluding pages with `show_tile` set to
`false` first, and only then iterating over the remaining pages.
This commit is contained in:
Meitar M 2020-01-31 14:21:40 -05:00
parent 8c70ecf005
commit 4e4f981b8c
No known key found for this signature in database
GPG key ID: 07EFAA28AB94BC85
1 changed files with 8 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
_includes/tiles.html
View file

@ -1,28 +1,18 @@
{% if 'posts' == site.tiles-source %}
{% assign tiles = site.posts %}
{% elsif 'pages' == site.tiles-source %}
{% assign tiles = site.html_pages | where_exp: "item", "item.show_tile != false" %}
{% endif %}
<section id="one" class="tiles">
{% for post in site.posts limit:site.tiles-count %}
{% if site.tiles-source == 'posts' %}
{% for tile in tiles limit:site.tiles-count %}
<article>
<span class="image">
<img src="{{ post.image }}" alt="" />
<img src="{{ tile.image }}" alt="" />
</span>
<header class="major">
<h3><a href="{{ post.url | relative_url }}" class="link">{{ post.title }}</a></h3>
<h3><a href="{{ tile.url | relative_url }}" class="link">{{ tile.title }}</a></h3>
<p>{{ post.description }}</p>
</header>
</article>
{% endif %}
{% endfor %}
{% for page in site.html_pages limit:site.tiles-count %}
{% if site.tiles-source == 'pages' and page.show_tile != false %}
<article>
<span class="image">
<img src="{{ page.image }}" alt="" />
</span>
<header class="major">
<h3><a href="{{ page.url | relative_url }}" class="link">{{ page.title }}</a></h3>
<p>{{ page.description }}</p>
</header>
</article>
{% endif %}
{% endfor %}
</section>