Jiri Kosina c949d4eb40 [PATCH] autofs: fix error code path in autofs_fill_sb() ... When kernel is compiled with old version of autofs (CONFIG_AUTOFS_FS), and new (observed at least with 5.x.x) automount deamon is started, kernel correctly reports incompatible version of kernel and userland daemon, but then screws things up instead of correct handling of the error: autofs: kernel does not match daemon version ===================================== [ BUG: bad unlock balance detected! ] ------------------------------------- automount/4199 is trying to release lock (&type->s_umount_key) at: [<c0163b9e>] get_sb_nodev+0x76/0xa4 but there are no more locks to release! other info that might help us debug this: no locks held by automount/4199. stack backtrace: [<c0103b15>] dump_trace+0x68/0x1b2 [<c0103c77>] show_trace_log_lvl+0x18/0x2c [<c01041db>] show_trace+0xf/0x11 [<c010424d>] dump_stack+0x12/0x14 [<c012e02c>] print_unlock_inbalance_bug+0xe7/0xf3 [<c012fd4f>] lock_release+0x8d/0x164 [<c012b452>] up_write+0x14/0x27 [<c0163b9e>] get_sb_nodev+0x76/0xa4 [<c0163689>] vfs_kern_mount+0x83/0xf6 [<c016373e>] do_kern_mount+0x2d/0x3e [<c017513f>] do_mount+0x607/0x67a [<c0175224>] sys_mount+0x72/0xa4 [<c0102b96>] sysenter_past_esp+0x5f/0x99 DWARF2 unwinder stuck at sysenter_past_esp+0x5f/0x99 Leftover inexact backtrace: ======================= and then deadlock comes. The problem: autofs_fill_super() returns EINVAL to get_sb_nodev(), but before that, it calls kill_anon_super() to destroy the superblock which won't be needed. This is however way too soon to call kill_anon_super(), because get_sb_nodev() has to perform its own cleanup of the superblock first (deactivate_super(), etc.). The correct time to call kill_anon_super() is in the autofs_kill_sb() callback, which is called by deactivate_super() at proper time, when the superblock is ready to be killed. I can see the same faulty codepath also in autofs4. This patch solves issues in both filesystems in a same way - it postpones the kill_anon_super() until the proper time is signalized by deactivate_super() calling the kill_sb() callback. [raven@themaw.net: update comment] Signed-off-by: Jiri Kosina <jkosina@suse.cz> Acked-by: Ian Kent <raven@themaw.net> Cc: <stable@kernel.org> Signed-off-by: Ian Kent <raven@themaw.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>		2006-12-07 08:39:43 -08:00
..
autofs_i.h	[PATCH] autofs3: Make sure all dentries refs are released before calling kill_anon_super()	2006-10-20 10:26:38 -07:00
dirhash.c	[PATCH] autofs3: Make sure all dentries refs are released before calling kill_anon_super()	2006-10-20 10:26:38 -07:00
init.c	[PATCH] autofs3: Make sure all dentries refs are released before calling kill_anon_super()	2006-10-20 10:26:38 -07:00
inode.c	[PATCH] autofs: fix error code path in autofs_fill_sb()	2006-12-07 08:39:43 -08:00
Makefile
root.c	[PATCH] r/o bind mount prepwork: inc_nlink() helper	2006-10-01 00:39:30 -07:00
symlink.c	[PATCH] inode_diet: Replace inode.u.generic_ip with inode.i_private	2006-09-27 08:26:17 -07:00
waitq.c	[PATCH] autofs4: panic after mount fail	2006-11-14 09:09:27 -08:00