Wu Fengguang b6fac63cc1 vfs: skip I_CLEAR state inodes ... clear_inode() will switch inode state from I_FREEING to I_CLEAR, and do so _outside_ of inode_lock. So any I_FREEING testing is incomplete without a coupled testing of I_CLEAR. So add I_CLEAR tests to drop_pagecache_sb(), generic_sync_sb_inodes() and add_dquot_ref(). Masayoshi MIZUMA discovered the bug in drop_pagecache_sb() and Jan Kara reminds fixing the other two cases. Masayoshi MIZUMA has a nice panic flow: ===================================================================== [process A] | [process B] | | | prune_icache() | drop_pagecache() | spin_lock(&inode_lock) | drop_pagecache_sb() | inode->i_state |= I_FREEING; | | | spin_unlock(&inode_lock) | V | | | spin_lock(&inode_lock) | V | | | dispose_list() | | | list_del() | | | clear_inode() | | | inode->i_state = I_CLEAR | | | | | V | | | if (inode->i_state & (I_FREEING|I_WILL_FREE)) | | | continue; <==== NOT MATCH | | | | | | (DANGER from here on! Accessing disposing inode!) | | | | | | __iget() | | | list_move() <===== PANIC on poisoned list !! V V | (time) ===================================================================== Reported-by: Masayoshi MIZUMA <m.mizuma@jp.fujitsu.com> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2009-04-02 19:04:48 -07:00
..
dquot.c	vfs: skip I_CLEAR state inodes	2009-04-02 19:04:48 -07:00
Kconfig	trivial: fix typos/grammar errors in fs/Kconfig	2009-03-26 02:18:38 +01:00
Makefile
quota.c	quota: Coding style fixes	2009-03-26 02:18:38 +01:00
quota_tree.c	quota: Coding style fixes	2009-03-26 02:18:38 +01:00
quota_tree.h
quota_v1.c	quota: Coding style fixes	2009-03-26 02:18:38 +01:00
quota_v2.c	quota: Coding style fixes	2009-03-26 02:18:38 +01:00
quotaio_v1.h
quotaio_v2.h