Arthur Jones c87591b719 ext3: wait on all pending commits in ext3_sync_fs ... In ext3_sync_fs, we only wait for a commit to finish if we started it, but there may be one already in progress which will not be synced. In the case of a data=ordered umount with pending long symlinks which are delayed due to a long list of other I/O on the backing block device, this causes the buffer associated with the long symlinks to not be moved to the inode dirty list in the second phase of fsync_super. Then, before they can be dirtied again, kjournald exits, seeing the UMOUNT flag and the dirty pages are never written to the backing block device, causing long symlink corruption and exposing new or previously freed block data to userspace. This can be reproduced with a script created by Eric Sandeen <sandeen@redhat.com>: #!/bin/bash umount /mnt/test2 mount /dev/sdb4 /mnt/test2 rm -f /mnt/test2/* dd if=/dev/zero of=/mnt/test2/bigfile bs=1M count=512 touch /mnt/test2/thisisveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverylongfilename ln -s /mnt/test2/thisisveryveryveryveryveryveryveryveryveryveryveryveryveryveryveryverylongfilename /mnt/test2/link umount /mnt/test2 mount /dev/sdb4 /mnt/test2 ls /mnt/test2/ umount /mnt/test2 To ensure all commits are synced, we flush all journal commits now when sync_fs'ing ext3. Signed-off-by: Arthur Jones <ajones@riverbed.com> Cc: Eric Sandeen <sandeen@redhat.com> Cc: Theodore Ts'o <tytso@mit.edu> Cc: <linux-ext4@vger.kernel.org> Cc: <stable@kernel.org> [2.6.everything] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2008-11-06 15:41:19 -08:00
..
9p	9p: fix format warning	2008-10-22 18:48:45 -05:00
adfs	vfs: Use const for kernel parser table	2008-10-13 10:10:37 -07:00
affs	vfs: Use const for kernel parser table	2008-10-13 10:10:37 -07:00
afs	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
autofs	vfs: Use const for kernel parser table	2008-10-13 10:10:37 -07:00
autofs4	autofs4: collect version check return	2008-11-06 15:41:17 -08:00
befs	befs: annotate fs32 on tests for superblock endianness	2008-10-16 11:21:46 -07:00
bfs	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
cifs	cifs: fix renaming one hardlink on top of another	2008-11-03 18:31:05 +00:00
coda	Switch to a valid email address...	2008-10-27 08:40:17 -07:00
configfs	[PATCH] assorted path_lookup() -> kern_path() conversions	2008-10-23 05:12:52 -04:00
cramfs
debugfs	integrity: special fs magic	2008-10-13 09:47:43 +11:00
devpts	vfs: Use const for kernel parser table	2008-10-13 10:10:37 -07:00
dlm
ecryptfs	ecryptfs: fix memory corruption when storing crypto info in xattrs	2008-10-30 11:38:46 -07:00
efs	[PATCH] switch all filesystems over to d_obtain_alias	2008-10-23 05:13:01 -04:00
exportfs	[PATCH] prepare vfs_readdir() callers to returning filldir result	2008-10-23 05:13:10 -04:00
ext2	Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev	2008-10-23 10:23:07 -07:00
ext3	ext3: wait on all pending commits in ext3_sync_fs	2008-11-06 15:41:19 -08:00
ext4	delay capable() check in ext4_has_free_blocks()	2008-10-28 00:08:17 -04:00
fat	fs: remove prepare_write/commit_write	2008-10-30 11:38:45 -07:00
freevxfs
fuse	saner FASYNC handling on file close	2008-11-01 09:49:46 -07:00
gfs2	[PATCH] switch all filesystems over to d_obtain_alias	2008-10-23 05:13:01 -04:00
hfs	[PATCH] move executable checking into ->permission()	2008-10-23 05:13:25 -04:00
hfsplus	[PATCH] move executable checking into ->permission()	2008-10-23 05:13:25 -04:00
hostfs	[PATCH] introduce fmode_t, do annotations	2008-10-21 07:47:06 -04:00
hpfs	[PATCH] hpfs: cleanup ->setattr	2008-10-23 05:12:58 -04:00
hppfs
hugetlbfs	vfs: Use const for kernel parser table	2008-10-13 10:10:37 -07:00
isofs	[PATCH] switch all filesystems over to d_obtain_alias	2008-10-23 05:13:01 -04:00
jbd	fs: remove excess kernel-doc	2008-10-30 11:38:46 -07:00
jbd2	jbd2: Call the commit callback before the transaction could get dropped	2008-10-28 21:08:20 -04:00
jffs2	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
jfs	Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev	2008-10-23 10:23:07 -07:00
lockd	NLM: Set address family before calling nlm_host_rebooted()	2008-10-30 17:19:30 -04:00
minix
msdos
ncpfs
nfs	NFS: Convert nfs_attr_generation_counter into an atomic_long	2008-10-28 15:21:40 -04:00
nfs_common
nfsd	nfsd: fix failure to set eof in readdir in some situations	2008-10-30 17:16:49 -04:00
nls	remove CONFIG_KMOD from fs	2008-10-17 02:38:36 +11:00
ntfs	[PATCH] switch all filesystems over to d_obtain_alias	2008-10-23 05:13:01 -04:00
ocfs2	fs: remove prepare_write/commit_write	2008-10-30 11:38:45 -07:00
omfs	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
openpromfs	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
partitions	[PATCH] sanitize blkdev_get() and friends	2008-10-21 07:49:06 -04:00
proc	Merge branch 'proc-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/adobriyan/proc	2008-11-03 09:59:01 -08:00
qnx4
ramfs	Ramfs and Ram Disk pages are unevictable	2008-10-20 08:50:26 -07:00
reiserfs	Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev	2008-10-23 10:23:07 -07:00
romfs
smbfs
sysfs	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
sysv
ubifs	Merge branch 'linux-next' of git://git.infradead.org/ubifs-2.6	2008-10-20 09:19:03 -07:00
udf	[PATCH] get rid of on-stack dentry in udf	2008-10-23 05:13:15 -04:00
ufs	[PATCH] fix ->llseek for more directories	2008-10-23 05:13:21 -04:00
vfat
xfs	Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev	2008-10-23 10:23:07 -07:00
aio.c
anon_inodes.c
attr.c	[patch] vfs: make security_inode_setattr() calling consistent	2008-10-23 05:13:27 -04:00
bad_inode.c
binfmt_aout.c
binfmt_elf.c	Merge branch 'v28-timers-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip	2008-10-20 13:19:56 -07:00
binfmt_elf_fdpic.c	binfmt_elf_fdpic: Update for cputime changes.	2008-10-20 20:17:18 -07:00
binfmt_em86.c	Allow recursion in binfmt_script and binfmt_misc	2008-10-16 11:21:38 -07:00
binfmt_flat.c	uclinux: fix gzip header parsing in binfmt_flat.c	2008-10-16 11:21:29 -07:00
binfmt_misc.c	Allow recursion in binfmt_script and binfmt_misc	2008-10-16 11:21:38 -07:00
binfmt_script.c	Allow recursion in binfmt_script and binfmt_misc	2008-10-16 11:21:38 -07:00
binfmt_som.c	binfmt_som.c: add MODULE_LICENSE	2008-10-16 11:21:38 -07:00
bio-integrity.c	block: Introduce integrity data ownership flag	2008-10-09 08:56:21 +02:00
bio.c	block: mark bio_split_pool static	2008-10-09 08:57:05 +02:00
block_dev.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev	2008-10-23 10:23:07 -07:00
buffer.c	fs: buffer lock use lock bitops	2008-10-20 08:52:32 -07:00
char_dev.c	[PATCH] tidy up chrdev_open	2008-10-23 05:12:59 -04:00
compat.c	select: deal with math overflow from borderline valid userland data	2008-10-26 11:22:08 -07:00
compat_binfmt_elf.c
compat_ioctl.c
dcache.c	[PATCH] fs: add a sanity check in d_free	2008-10-23 05:17:12 -04:00
dcookies.c
direct-io.c	Remove Andrew Morton's old email accounts	2008-10-16 11:21:32 -07:00
dnotify.c
dquot.c	[PATCH] switch quota_on-related stuff to kern_path()	2008-10-23 05:12:44 -04:00
drop_caches.c
eventfd.c
eventpoll.c	epoll: avoid double-inserts in case of EFAULT	2008-10-26 12:09:49 -07:00
exec.c	coredump: format_corename: don't append .%pid if multi-threaded	2008-10-20 08:52:39 -07:00
fcntl.c
fifo.c	[PATCH] introduce fmode_t, do annotations	2008-10-21 07:47:06 -04:00
file.c
file_table.c	saner FASYNC handling on file close	2008-11-01 09:49:46 -07:00
filesystems.c	proc: move /proc/filesystems to fs/filesystems.c	2008-10-23 14:27:09 +04:00
fs-writeback.c	Remove Andrew Morton's old email accounts	2008-10-16 11:21:32 -07:00
generic_acl.c
inode.c
inotify.c
inotify_user.c	saner FASYNC handling on file close	2008-11-01 09:49:46 -07:00
internal.h
ioctl.c	provide generic_block_fiemap() only with BLOCK=y	2008-10-12 11:44:37 -07:00
ioprio.c
Kconfig	[patch 1/3] FS_MBCACHE: don't needlessly make it built-in	2008-10-23 05:13:26 -04:00
Kconfig.binfmt	add CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS	2008-10-20 08:52:39 -07:00
libfs.c	fs: remove prepare_write/commit_write	2008-10-30 11:38:45 -07:00
locks.c	Merge branch 'proc' of git://git.kernel.org/pub/scm/linux/kernel/git/adobriyan/proc	2008-10-23 12:04:37 -07:00
Makefile	Configure out AIO support	2008-10-16 11:21:51 -07:00
mbcache.c
mpage.c	Remove Andrew Morton's old email accounts	2008-10-16 11:21:32 -07:00
namei.c	[PATCH] move executable checking into ->permission()	2008-10-23 05:13:25 -04:00
namespace.c	[RFC PATCH] touch_mnt_namespace when the mount flags change	2008-10-23 05:13:23 -04:00
nfsctl.c
no-block.c
open.c	[PATCH] introduce fmode_t, do annotations	2008-10-21 07:47:06 -04:00
pipe.c	saner FASYNC handling on file close	2008-11-01 09:49:46 -07:00
pnode.c
pnode.h
posix_acl.c
quota.c
quota_v1.c
quota_v2.c
read_write.c	[PATCH] generic_file_llseek tidyups	2008-10-23 05:12:59 -04:00
read_write.h
readdir.c	[PATCH] prepare vfs_readdir() callers to returning filldir result	2008-10-23 05:13:10 -04:00
select.c	select: deal with math overflow from borderline valid userland data	2008-10-26 11:22:08 -07:00
seq_file.c	seq_file: add seq_cpumask_list(), seq_nodemask_list()	2008-10-20 08:52:39 -07:00
signalfd.c
splice.c	fs: remove prepare_write/commit_write	2008-10-30 11:38:45 -07:00
stack.c
stat.c
super.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/viro/bdev	2008-10-23 10:23:07 -07:00
sync.c
timerfd.c	hrtimer: convert timerfd to the new hrtimer apis	2008-09-05 21:35:09 -07:00
utimes.c
xattr.c
xattr_acl.c