Rafael Laufer 418372b0ab sctp: fix missing destroy of percpu counter variable in sctp_proc_exit() ... Commit 1748376b66, net: Use a percpu_counter for sockets_allocated added percpu_counter function calls to sctp_proc_init code path, but forgot to add them to sctp_proc_exit(). This resulted in a following Ooops when performing this test # modprobe sctp # rmmod -f sctp # modprobe sctp [ 573.862512] BUG: unable to handle kernel paging request at f8214a24 [ 573.862518] IP: [<c0308b8f>] __percpu_counter_init+0x3f/0x70 [ 573.862530] *pde = 37010067 *pte = 00000000 [ 573.862534] Oops: 0002 [#1] SMP [ 573.862537] last sysfs file: /sys/module/libcrc32c/initstate [ 573.862540] Modules linked in: sctp(+) crc32c libcrc32c binfmt_misc bridge stp bnep lp snd_hda_codec_analog snd_hda_intel snd_hda_codec snd_hwdep snd_pcm_oss snd_mixer_oss arc4 joydev snd_pcm ecb pcmcia snd_seq_dummy snd_seq_oss iwlagn iwlcore snd_seq_midi snd_rawmidi snd_seq_midi_event yenta_socket rsrc_nonstatic thinkpad_acpi snd_seq snd_timer snd_seq_device mac80211 psmouse sdhci_pci sdhci nvidia(P) ppdev video snd soundcore serio_raw pcspkr iTCO_wdt iTCO_vendor_support led_class ricoh_mmc pcmcia_core intel_agp nvram agpgart usbhid parport_pc parport output snd_page_alloc cfg80211 btusb ohci1394 ieee1394 e1000e [last unloaded: sctp] [ 573.862589] [ 573.862593] Pid: 5373, comm: modprobe Tainted: P R (2.6.31-rc3 #6) 7663B15 [ 573.862596] EIP: 0060:[<c0308b8f>] EFLAGS: 00010286 CPU: 1 [ 573.862599] EIP is at __percpu_counter_init+0x3f/0x70 [ 573.862602] EAX: f8214a20 EBX: f80faa14 ECX: c48c0000 EDX: f80faa20 [ 573.862604] ESI: f80a7000 EDI: 00000000 EBP: f69d5ef0 ESP: f69d5eec [ 573.862606] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 [ 573.862610] Process modprobe (pid: 5373, ti=f69d4000 task=c2130c70 task.ti=f69d4000) [ 573.862612] Stack: [ 573.862613] 00000000 f69d5f18 f80a70a8 f80fa9fc 00000000 fffffffc f69d5f30 c018e2d4 [ 573.862619] <0> 00000000 f80a7000 00000000 f69d5f88 c010112b 00000000 c07029c0 fffffffb [ 573.862626] <0> 00000000 f69d5f38 c018f83f f69d5f54 c0557cad f80fa860 00000001 c07010c0 [ 573.862634] Call Trace: [ 573.862644] [<f80a70a8>] ? sctp_init+0xa8/0x7d4 [sctp] [ 573.862650] [<c018e2d4>] ? marker_update_probe_range+0x184/0x260 [ 573.862659] [<f80a7000>] ? sctp_init+0x0/0x7d4 [sctp] [ 573.862662] [<c010112b>] ? do_one_initcall+0x2b/0x160 [ 573.862666] [<c018f83f>] ? tracepoint_module_notify+0x2f/0x40 [ 573.862671] [<c0557cad>] ? notifier_call_chain+0x2d/0x70 [ 573.862678] [<c01588fd>] ? __blocking_notifier_call_chain+0x4d/0x60 [ 573.862682] [<c016b2f1>] ? sys_init_module+0xb1/0x1f0 [ 573.862686] [<c0102ffc>] ? sysenter_do_call+0x12/0x28 [ 573.862688] Code: 89 48 08 b8 04 00 00 00 e8 df aa ec ff ba f4 ff ff ff 85 c0 89 43 14 74 31 b8 b0 18 71 c0 e8 19 b9 24 00 a1 c4 18 71 c0 8d 53 0c <89> 50 04 89 43 0c b8 b0 18 71 c0 c7 43 10 c4 18 71 c0 89 15 c4 [ 573.862725] EIP: [<c0308b8f>] __percpu_counter_init+0x3f/0x70 SS:ESP 0068:f69d5eec [ 573.862730] CR2: 00000000f8214a24 [ 573.862734] ---[ end trace 39c4e0b55e7cf54d ]--- Signed-off-by: Rafael Laufer <rlaufer@cisco.com> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2009-08-09 21:45:43 -07:00
..
9p	9p: Possible regression in p9_client_stat	2009-07-14 15:54:41 -05:00
802	net: remove COMPAT_NET_DEV_OPS	2009-05-25 01:53:53 -07:00
8021q	8021q: Vlan driver should use rcu_barrier() on unload instead of syncronize_net()	2009-06-10 01:11:22 -07:00
appletalk	Merge branch 'master' of /home/davem/src/GIT/linux-2.6/	2009-08-09 21:29:47 -07:00
atm	net: adding memory barrier to the poll and receive callbacks	2009-07-09 17:06:57 -07:00
ax25	net: Move rx skb_orphan call to where needed	2009-06-23 16:36:25 -07:00
bluetooth	bluetooth: rfcomm_init bug fix	2009-08-03 13:24:39 -07:00
bridge	net/bridge: use kobject_put to release kobject in br_add_if error path	2009-07-26 19:20:51 -07:00
can	can: Fix raw_getname() leak	2009-08-09 21:45:32 -07:00
core	net: Fix spinlock use in alloc_netdev_mq()	2009-08-05 08:35:11 -07:00
dcb
dccp	Merge branch 'master' of /home/davem/src/GIT/linux-2.6/	2009-08-09 21:29:47 -07:00
decnet	decnet: Use rcu_barrier() on module unload.	2009-06-26 13:51:27 -07:00
dsa	dsa: fix 88e6xxx statistics counter snapshotting	2009-07-05 18:03:35 -07:00
econet	econet: Fix econet_getname() leak	2009-08-06 13:08:40 -07:00
ethernet	net: remove COMPAT_NET_DEV_OPS	2009-05-25 01:53:53 -07:00
ieee802154	af_ieee802154: provide dummy get/setsockopt	2009-08-06 12:49:19 +04:00
ipv4	ipv4: ARP neigh procfs buffer overflow	2009-07-30 13:27:29 -07:00
ipv6	tcp: Use correct peer adr when copying MD5 keys	2009-07-20 07:49:08 -07:00
ipx	headers: smp_lock.h redux	2009-07-12 12:22:34 -07:00
irda	Merge branch 'master' of /home/davem/src/GIT/linux-2.6/	2009-08-09 21:29:47 -07:00
iucv	net: adding memory barrier to the poll and receive callbacks	2009-07-09 17:06:57 -07:00
key	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
lapb
llc	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
mac80211	mac80211: fix suspend	2009-07-29 14:52:01 -04:00
netfilter	netfilter: nf_conntrack: nf_conntrack_alloc() fixes	2009-07-16 14:03:40 +02:00
netlabel	net/netlabel: Add kmalloc NULL tests	2009-07-30 10:58:28 -07:00
netlink	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
netrom	netrom: Fix nr_getname() leak	2009-08-06 13:08:43 -07:00
packet	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
phonet	phonet: phonet_device_get() fix	2009-08-05 12:14:09 -07:00
rds	Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6	2009-05-18 21:08:20 -07:00
rfkill	rfkill: fix rfkill_set_states() to set the hw state	2009-07-21 12:07:38 -04:00
rose	rose: Fix rose_getname() leak	2009-08-06 13:08:38 -07:00
rxrpc	net: adding memory barrier to the poll and receive callbacks	2009-07-09 17:06:57 -07:00
sched	net: correct off-by-one write allocations reports	2009-06-18 00:29:12 -07:00
sctp	sctp: fix missing destroy of percpu counter variable in sctp_proc_exit()	2009-08-09 21:45:43 -07:00
sunrpc	headers: smp_lock.h redux	2009-07-12 12:22:34 -07:00
tipc	tipc: Use genl_register_family_with_ops()	2009-05-21 16:50:23 -07:00
unix	net: adding memory barrier to the poll and receive callbacks	2009-07-09 17:06:57 -07:00
wanrouter	headers: smp_lock.h redux	2009-07-12 12:22:34 -07:00
wimax	wimax: fix warning caused by not checking retval of rfkill_set_hw_state()	2009-06-11 11:12:48 -07:00
wireless	cfg80211: fix regression on beacon world roaming feature	2009-08-03 16:31:21 -04:00
x25	headers: smp_lock.h redux	2009-07-12 12:22:34 -07:00
xfrm	Fix xfrm hash collisions by changing __xfrm4_daddr_saddr_hash to hash addresses with addition	2009-08-09 21:45:31 -07:00
compat.c
Kconfig	net: add IEEE 802.15.4 socket family implementation	2009-06-09 05:25:32 -07:00
Makefile	net: add IEEE 802.15.4 socket family implementation	2009-06-09 05:25:32 -07:00
nonet.c
socket.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6	2009-04-06 18:05:43 -07:00
sysctl_net.c
TUNABLE