aha/drivers/isdn
Andrew Morton 5e6c20a93b isdn/capi warning fixes
drivers/isdn/capi/capi.c: In function 'handle_minor_send':
drivers/isdn/capi/capi.c:552: warning: cast from pointer to integer of different size

Of course, the code here might actually be buggy, in which case this patch
should not be applied?

Answer:

  No this field is ignored inside linux kernel.Yes this is ugly, but it's
  the CAPI spec for all OS.

  CAPI DATA_B3 Request/Indication CAPI Message has a mandatory field which
  represent the 32 bit buffer address of the payload data.  In linux the
  payload data do not use a sperate buffer, data follows directely after the
  CAPI Message in the same skb and we use this assumption inside the drivers,
  so we can ignore this field.

  Inside the linux CAPI implemetation we never use this field, so it could
  also have no value, but since random data in a message is bad as well (e.g.
  displayed in CAPI traces) we set is to the most adequate value.

  Outside the kernel the capi20 library sets the correct addresses (there is
  an optional second field for 64 bit adresses for 64 bit systems, we do not
  use here).

Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-07-17 10:23:06 -07:00
..
act2000 [SK_BUFF]: Introduce skb_copy_from_linear_data{_offset} 2007-04-25 22:28:23 -07:00
capi isdn/capi warning fixes 2007-07-17 10:23:06 -07:00
divert header cleaning: don't include smp_lock.h when not used 2007-05-08 11:15:07 -07:00
gigaset usb_gigaset: don't kmalloc(0) 2007-05-08 20:41:14 -07:00
hardware Use menuconfig objects: ISDN: CONFIG_CAPI_EICON 2007-07-17 10:23:06 -07:00
hisax sane irq initialization in sedlbauer hisax 2007-07-17 10:23:05 -07:00
hysdn ISDN: Spinlock initializer cleanup 2007-05-08 11:15:17 -07:00
i4l Use menuconfig objects: ISDN: CONFIG_ISDN 2007-07-17 10:23:05 -07:00
icn Detach sched.h from mm.h 2007-05-21 09:18:19 -07:00
isdnloop ISDN: Spinlock initializer cleanup 2007-05-08 11:15:17 -07:00
pcbit [SK_BUFF]: Introduce skb_copy_from_linear_data{_offset} 2007-04-25 22:28:23 -07:00
sc Detach sched.h from mm.h 2007-05-21 09:18:19 -07:00
Kconfig Use menuconfig objects: ISDN: CONFIG_ISDN_CAPI 2007-07-17 10:23:05 -07:00
Makefile [PATCH] isdn4linux: Siemens Gigaset drivers - Kconfigs and Makefiles 2006-03-26 08:57:05 -08:00