mirror of
https://github.com/adulau/aha.git
synced 2024-12-28 11:46:19 +00:00
4ecc8c066f
The following code appears in the function fs_init_instance in the file drivers/net/fs_enet/fs_enet-main.c.
if (fep->ops == NULL) {
printk(KERN_ERR DRV_MODULE_NAME
": %s No matching ops found (%d).\n",
ndev->name, fpi->fs_no);
err = -EINVAL;
goto err;
}
This code implies that at the point of err, fep->ops can be NULL, so an
extra test is needed before dereferencing this value.
This problem was found using the following semantic match
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression E, E1;
identifier f;
statement S1,S2,S3;
@@
* if (E == NULL)
{
... when != if (E == NULL) S1 else S2
when != E = E1
* E->f
... when any
return ...;
}
else S3
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
|
||
|---|---|---|
| .. | ||
| fec.h | ||
| fs_enet-main.c | ||
| fs_enet.h | ||
| Kconfig | ||
| mac-fcc.c | ||
| mac-fec.c | ||
| mac-scc.c | ||
| Makefile | ||
| mii-bitbang.c | ||
| mii-fec.c | ||