tracing: clean up tracing profiler

Ingo Molnar suggested clean ups for the profiling code. This patch
makes those updates.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
This commit is contained in:
Steven Rostedt 2009-03-25 13:26:41 -04:00
parent a2a16d6a31
commit fb9fb015e9

View file

@ -69,7 +69,7 @@ static DEFINE_MUTEX(ftrace_lock);
static struct ftrace_ops ftrace_list_end __read_mostly = static struct ftrace_ops ftrace_list_end __read_mostly =
{ {
.func = ftrace_stub, .func = ftrace_stub,
}; };
static struct ftrace_ops *ftrace_list __read_mostly = &ftrace_list_end; static struct ftrace_ops *ftrace_list __read_mostly = &ftrace_list_end;
@ -271,8 +271,10 @@ struct ftrace_profile_stat {
#define PROFILES_PER_PAGE \ #define PROFILES_PER_PAGE \
(PROFILE_RECORDS_SIZE / sizeof(struct ftrace_profile)) (PROFILE_RECORDS_SIZE / sizeof(struct ftrace_profile))
static int ftrace_profile_bits; static int ftrace_profile_bits __read_mostly;
static int ftrace_profile_enabled; static int ftrace_profile_enabled __read_mostly;
/* ftrace_profile_lock - synchronize the enable and disable of the profiler */
static DEFINE_MUTEX(ftrace_profile_lock); static DEFINE_MUTEX(ftrace_profile_lock);
static DEFINE_PER_CPU(struct ftrace_profile_stat, ftrace_profile_stats); static DEFINE_PER_CPU(struct ftrace_profile_stat, ftrace_profile_stats);
@ -651,7 +653,7 @@ static void unregister_ftrace_profiler(void)
#else #else
static struct ftrace_ops ftrace_profile_ops __read_mostly = static struct ftrace_ops ftrace_profile_ops __read_mostly =
{ {
.func = function_profile_call, .func = function_profile_call,
}; };
static int register_ftrace_profiler(void) static int register_ftrace_profiler(void)
@ -670,7 +672,7 @@ ftrace_profile_write(struct file *filp, const char __user *ubuf,
size_t cnt, loff_t *ppos) size_t cnt, loff_t *ppos)
{ {
unsigned long val; unsigned long val;
char buf[64]; char buf[64]; /* big enough to hold a number */
int ret; int ret;
if (cnt >= sizeof(buf)) if (cnt >= sizeof(buf))
@ -719,7 +721,7 @@ static ssize_t
ftrace_profile_read(struct file *filp, char __user *ubuf, ftrace_profile_read(struct file *filp, char __user *ubuf,
size_t cnt, loff_t *ppos) size_t cnt, loff_t *ppos)
{ {
char buf[64]; char buf[64]; /* big enough to hold a number */
int r; int r;
r = sprintf(buf, "%u\n", ftrace_profile_enabled); r = sprintf(buf, "%u\n", ftrace_profile_enabled);
@ -734,12 +736,12 @@ static const struct file_operations ftrace_profile_fops = {
/* used to initialize the real stat files */ /* used to initialize the real stat files */
static struct tracer_stat function_stats __initdata = { static struct tracer_stat function_stats __initdata = {
.name = "functions", .name = "functions",
.stat_start = function_stat_start, .stat_start = function_stat_start,
.stat_next = function_stat_next, .stat_next = function_stat_next,
.stat_cmp = function_stat_cmp, .stat_cmp = function_stat_cmp,
.stat_headers = function_stat_headers, .stat_headers = function_stat_headers,
.stat_show = function_stat_show .stat_show = function_stat_show
}; };
static void ftrace_profile_debugfs(struct dentry *d_tracer) static void ftrace_profile_debugfs(struct dentry *d_tracer)
@ -1954,7 +1956,7 @@ function_trace_probe_call(unsigned long ip, unsigned long parent_ip)
static struct ftrace_ops trace_probe_ops __read_mostly = static struct ftrace_ops trace_probe_ops __read_mostly =
{ {
.func = function_trace_probe_call, .func = function_trace_probe_call,
}; };
static int ftrace_probe_registered; static int ftrace_probe_registered;