mirror of
https://github.com/adulau/aha.git
synced 2024-12-28 19:56:18 +00:00
seq-midi: always log message on output overrun
It turns out that the main cause of output buffer overruns is not slow drivers but applications that generate too many messages. Therefore, it makes more sense to make that error message always visible, and to rate-limit it. Signed-off-by: Clemens Ladisch <clemens@ladisch.de> Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
parent
6847e154e3
commit
f907ed94f9
1 changed files with 2 additions and 1 deletions
|
@ -120,7 +120,8 @@ static int dump_midi(struct snd_rawmidi_substream *substream, const char *buf, i
|
|||
return -EINVAL;
|
||||
runtime = substream->runtime;
|
||||
if ((tmp = runtime->avail) < count) {
|
||||
snd_printd("warning, output event was lost (count = %i, available = %i)\n", count, tmp);
|
||||
if (printk_ratelimit())
|
||||
snd_printk(KERN_ERR "MIDI output buffer overrun\n");
|
||||
return -ENOMEM;
|
||||
}
|
||||
if (snd_rawmidi_kernel_write(substream, buf, count) < count)
|
||||
|
|
Loading…
Reference in a new issue