adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-30 20:56:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

IB/ucm: Fix deadlock in cleanup

Browse source 
ib_ucm_cleanup_events() holds file_mutex while calling ib_destroy_cm_id().
This can deadlock since ib_destroy_cm_id() flushes event handlers, and
ib_ucm_event_handler() needs file_mutex, too.  Therefore, drop the
file_mutex during the call to ib_destroy_cm_id().

Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
Michael S. Tsirkin 2006-11-29 15:33:10 -08:00 committed by Roland Dreier
parent e1444b5a16
commit f469b2626f
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/infiniband/core/ucm.c
View file

@ -161,12 +161,14 @@ static void ib_ucm_cleanup_events(struct ib_ucm_context *ctx)
struct ib_ucm_event, ctx_list); struct ib_ucm_event, ctx_list);
list_del(&uevent->file_list); list_del(&uevent->file_list);
list_del(&uevent->ctx_list); list_del(&uevent->ctx_list);
mutex_unlock(&ctx->file->file_mutex);
/* clear incoming connections. */ /* clear incoming connections. */
if (ib_ucm_new_cm_id(uevent->resp.event)) if (ib_ucm_new_cm_id(uevent->resp.event))
ib_destroy_cm_id(uevent->cm_id); ib_destroy_cm_id(uevent->cm_id);
kfree(uevent); kfree(uevent);
mutex_lock(&ctx->file->file_mutex);
} }
mutex_unlock(&ctx->file->file_mutex); mutex_unlock(&ctx->file->file_mutex);
} }