adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 19:26:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

efirtc: explicitly set llseek to no_llseek

Browse source 
Now that we've removed the BKL here, let's explicitly set llseek to
no_llseek since the default llseek is not used here.

The default_llseek function still contains the BKL.  When we are auditing
code to see if we can remove the BKL, this is one of the hidden
considerations we need to take into account.  i.e., is there
syncronization between code that has the BKL and llseek.

At the same time we remove the BKL it would be a good idea to do indicate
when no llseek function is required, so we don't have to revisit this code
again, when we are trying to determine if we can remove the BKL from the
default_llseek.

Signed-off-by: John Kacur <jkacur@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
John Kacur 2009-12-15 16:46:06 -08:00 committed by Linus Torvalds
parent 50e49bee3f
commit f29627c2a3
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/char/efirtc.c
View file

@ -285,6 +285,7 @@ static const struct file_operations efi_rtc_fops = {
.unlocked_ioctl = efi_rtc_ioctl, .unlocked_ioctl = efi_rtc_ioctl,
.open = efi_rtc_open, .open = efi_rtc_open,
.release = efi_rtc_close, .release = efi_rtc_close,
.llseek = no_llseek,
}; };
static struct miscdevice efi_rtc_dev= { static struct miscdevice efi_rtc_dev= {