adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

ALSA: sound/aoa: Add kmalloc NULL tests

Browse source 
Check that the result of kzalloc is not NULL before a dereference.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression *x;
identifier f;
constant char *C;
@@

x = \(kmalloc\|kcalloc\|kzalloc\)(...);
... when != x == NULL
    when != x != NULL
    when != (x || ...)
(
kfree(x)
|
f(...,C,...,x,...)
|
*f(...,x,...)
|
*x->f
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Julia Lawall 2009-07-31 08:32:03 +02:00 committed by Takashi Iwai
parent 34fdeb2d07
commit f065fabc86
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
sound/aoa/core/gpio-pmf.c
View file

@ -182,6 +182,10 @@ static int pmf_set_notify(struct gpio_runtime *rt,
if (!old && notify) { if (!old && notify) {
irq_client = kzalloc(sizeof(struct pmf_irq_client), irq_client = kzalloc(sizeof(struct pmf_irq_client),
GFP_KERNEL); GFP_KERNEL);
if (!irq_client) {
err = -ENOMEM;
goto out_unlock;
}
irq_client->data = notif; irq_client->data = notif;
irq_client->handler = pmf_handle_notify_irq; irq_client->handler = pmf_handle_notify_irq;
irq_client->owner = THIS_MODULE; irq_client->owner = THIS_MODULE;