adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

UBIFS: list usage cleanup

Browse source 
Trivial cleanup, list_del(); list_add{,_tail}() is equivalent
to list_move{,_tail}(). Semantic patch for coccinelle can be
found at www.cccmz.de/~snakebyte/list_move_tail.spatch

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
This commit is contained in:
Eric Sesterhenn 2009-02-13 09:13:11 +01:00 committed by Artem Bityutskiy
parent 2bc275e9b0
commit ec32816f94
2 changed files with 3 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/ubifs/log.c
View file

@ -367,7 +367,6 @@ static void remove_buds(struct ubifs_info *c)
bud->jhead, c->leb_size - bud->start, bud->jhead, c->leb_size - bud->start,
c->cmt_bud_bytes); c->cmt_bud_bytes);
rb_erase(p1, &c->buds); rb_erase(p1, &c->buds);
list_del(&bud->list);
/* /*
* If the commit does not finish, the recovery will need * If the commit does not finish, the recovery will need
* to replay the journal, in which case the old buds * to replay the journal, in which case the old buds
@ -375,7 +374,7 @@ static void remove_buds(struct ubifs_info *c)
* commit i.e. do not allow them to be garbage * commit i.e. do not allow them to be garbage
* collected. * collected.
*/ */
list_add(&bud->list, &c->old_buds); list_move(&bud->list, &c->old_buds);
} }
} }
spin_unlock(&c->buds_lock); spin_unlock(&c->buds_lock);

6
fs/ubifs/shrinker.c
View file

@ -206,8 +206,7 @@ static int shrink_tnc_trees(int nr, int age, int *contention)
* Move this one to the end of the list to provide some * Move this one to the end of the list to provide some
* fairness. * fairness.
*/ */
list_del(&c->infos_list); list_move_tail(&c->infos_list, &ubifs_infos);
list_add_tail(&c->infos_list, &ubifs_infos);
mutex_unlock(&c->umount_mutex); mutex_unlock(&c->umount_mutex);
if (freed >= nr) if (freed >= nr)
break; break;
@ -263,8 +262,7 @@ static int kick_a_thread(void)
} }
if (i == 1) { if (i == 1) {
list_del(&c->infos_list); list_move_tail(&c->infos_list, &ubifs_infos);
list_add_tail(&c->infos_list, &ubifs_infos);
spin_unlock(&ubifs_infos_lock); spin_unlock(&ubifs_infos_lock);
ubifs_request_bg_commit(c); ubifs_request_bg_commit(c);