mirror of
https://github.com/adulau/aha.git
synced 2024-12-27 19:26:25 +00:00
devres: WARN() and return, don't crash on device_del() of uninitialized device
I just debugged an obscure crash caused by a device_del() of a all NULL'd out struct device (in usb-serial) and found that a patch like this one would have saved me time (in addition to improved chances of a bug report from users hitting similar driver bugs). [akpm@linux-foundation.org: cleanup] Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Kay Sievers <kay.sievers@vrfy.org> Cc: Tejun Heo <tj@kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
81e4e1ba7e
commit
eb8d3c604f
1 changed files with 3 additions and 0 deletions
|
@ -428,6 +428,9 @@ int devres_release_all(struct device *dev)
|
|||
{
|
||||
unsigned long flags;
|
||||
|
||||
/* Looks like an uninitialized device structure */
|
||||
if (WARN_ON(dev->devres_head.next == NULL))
|
||||
return -ENODEV;
|
||||
spin_lock_irqsave(&dev->devres_lock, flags);
|
||||
return release_nodes(dev, dev->devres_head.next, &dev->devres_head,
|
||||
flags);
|
||||
|
|
Loading…
Reference in a new issue