adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 19:26:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

parisc: Remove BKL from eisa_eeprom

Browse source 
Remove the empty ioctl and the cycle_kernel_lock() in
eisa_eeprom_open() which got there with the big BKL push down. There
is nothing to wait for and sychronize with after the misc device has
been registered.

Remove the empty ioctl as well. The generic code handles the -ENOTTY
if no ioctl function is provided.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <20091010153350.086917493@linutronix.de>
Cc: Kyle McMartin <kyle@parisc-linux.org>
This commit is contained in:
Thomas Gleixner 2009-10-10 15:33:17 +02:00
parent a5ee6dc9eb
commit eb29b758a8
1 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/parisc/eisa_eeprom.c
View file

@ -75,17 +75,8 @@ static ssize_t eisa_eeprom_read(struct file * file,
return ret; return ret;
} }
static int eisa_eeprom_ioctl(struct inode *inode, struct file *file,
unsigned int cmd,
unsigned long arg)
{
return -ENOTTY;
}
static int eisa_eeprom_open(struct inode *inode, struct file *file) static int eisa_eeprom_open(struct inode *inode, struct file *file)
{ {
cycle_kernel_lock();
if (file->f_mode & FMODE_WRITE) if (file->f_mode & FMODE_WRITE)
return -EINVAL; return -EINVAL;
@ -104,7 +95,6 @@ static const struct file_operations eisa_eeprom_fops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.llseek = eisa_eeprom_llseek, .llseek = eisa_eeprom_llseek,
.read = eisa_eeprom_read, .read = eisa_eeprom_read,
.ioctl = eisa_eeprom_ioctl,
.open = eisa_eeprom_open, .open = eisa_eeprom_open,
.release = eisa_eeprom_release, .release = eisa_eeprom_release,
}; };