adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

perfcounter: Handle some IO return values

Browse source 
Building perfcounter tools raises the following warnings:

 builtin-record.c: In function ‘atexit_header’:
 builtin-record.c:464: erreur: ignoring return value of ‘pwrite’, declared with attribute warn_unused_result
 builtin-record.c: In function ‘__cmd_record’:
 builtin-record.c:503: erreur: ignoring return value of ‘read’, declared with attribute warn_unused_result

 builtin-report.c: In function ‘__cmd_report’:
 builtin-report.c:1403: erreur: ignoring return value of ‘read’, declared with attribute warn_unused_result

This patch handles these IO return values.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <1245456100-5477-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Frederic Weisbecker 2009-06-20 02:01:40 +02:00 committed by Ingo Molnar
parent 92bf309a9c
commit eadc84cc01
2 changed files with 11 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
tools/perf/builtin-record.c
View file

@ -461,7 +461,8 @@ static void atexit_header(void)
{ {
file_header.data_size += bytes_written; file_header.data_size += bytes_written;
pwrite(output, &file_header, sizeof(file_header), 0); if (pwrite(output, &file_header, sizeof(file_header), 0) == -1)
perror("failed to write on file headers");
} }
static int __cmd_record(int argc, const char **argv) static int __cmd_record(int argc, const char **argv)
@ -500,7 +501,11 @@ static int __cmd_record(int argc, const char **argv)
} }
if (!file_new) { if (!file_new) {
read(output, &file_header, sizeof(file_header)); if (read(output, &file_header, sizeof(file_header)) == -1) {
perror("failed to read file headers");
exit(-1);
}
lseek(output, file_header.data_size, SEEK_CUR); lseek(output, file_header.data_size, SEEK_CUR);
} }

5
tools/perf/builtin-report.c
View file

@ -1400,7 +1400,10 @@ static int __cmd_report(void)
exit(0); exit(0);
} }
read(input, &file_header, sizeof(file_header)); if (read(input, &file_header, sizeof(file_header)) == -1) {
perror("failed to read file headers");
exit(-1);
}
if (sort__has_parent && if (sort__has_parent &&
!(file_header.sample_type & PERF_SAMPLE_CALLCHAIN)) { !(file_header.sample_type & PERF_SAMPLE_CALLCHAIN)) {