adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-30 20:56:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

PCI: pcie, aer: report multiple/first error on a device

Browse source 
Multiple bits might be set in the Uncorrectable Error Status
register.  But aer_print_error_source() only report a error of
the lowest bit set in the error status register.

So print strings for all bits unmasked and set.

And check First Error Pointer to mark the error occured first.
This FEP is not valid when the corresponing bit of the Uncorrectable
Error Status register is not set, or unimplemented or undefined.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
Hidetoshi Seto 2009-09-07 17:13:42 +09:00 committed by Jesse Barnes
parent 0d90c3ac0b
commit e7a0d92b19
3 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/pci/pcie/aer/aerdrv.h
View file

@ -61,6 +61,7 @@ struct aer_err_info {
u16 id;
int severity; /* 0:NONFATAL | 1:FATAL | 2:COR */
int flags;
int first;
unsigned int status; /* COR/UNCOR Error Status */
unsigned int mask; /* COR/UNCOR Error Mask */
struct header_log_regs tlp; /* TLP Header */

6
drivers/pci/pcie/aer/aerdrv_core.c
View file

@ -698,7 +698,7 @@ static struct aer_err_source *get_e_source(struct aer_rpc *rpc)
static int get_device_error_info(struct pci_dev *dev, struct aer_err_info *info)
{
int pos;
int pos, temp;
info->status = 0;
info->flags &= ~AER_TLP_HEADER_VALID_FLAG;
@ -727,6 +727,10 @@ static int get_device_error_info(struct pci_dev *dev, struct aer_err_info *info)
if (!(info->status & ~info->mask))
return AER_UNSUCCESS;
/* Get First Error Pointer */
pci_read_config_dword(dev, pos + PCI_ERR_CAP, &temp);
info->first = PCI_ERR_CAP_FEP(temp);
if (info->status & AER_LOG_TLP_MASKS) {
info->flags |= AER_TLP_HEADER_VALID_FLAG;
pci_read_config_dword(dev,

8
drivers/pci/pcie/aer/aerdrv_errprint.c
View file

@ -169,11 +169,11 @@ static void aer_print_error_source(struct aer_err_info *info)
errmsg = aer_uncorrectable_error_string[i];
if (errmsg)
AER_PR(info, "%s\t:\n", errmsg);
AER_PR(info, "%s\t: %s\n", errmsg,
info->first == i ? "First" : "");
else
AER_PR(info, "Unknown Error Bit %2d \t:\n", i);
break;
AER_PR(info, "Unknown Error Bit %2d \t: %s\n",
i, info->first == i ? "First" : "");
}
}