adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

[PATCH] checklist update

Browse source 
Update Documentation/SubmitChecklist.

- Mention lockdep coverage

- Describe documentation requirements

- Number the various items to simplify the composition of caustic emails.

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Andrew Morton 2006-07-10 04:45:42 -07:00 committed by Linus Torvalds
parent e62c23c751
commit e54695a59c
1 changed files with 41 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

76
Documentation/SubmitChecklist
View file

@ -1,57 +1,63 @@
Linux Kernel patch sumbittal checklist Linux Kernel patch sumbittal checklist
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Here are some basic things that developers should do if they Here are some basic things that developers should do if they want to see their
want to see their kernel patch submittals accepted quicker. kernel patch submissions accepted more quickly.
These are all above and beyond the documentation that is provided These are all above and beyond the documentation that is provided in
in Documentation/SubmittingPatches and elsewhere about submitting Documentation/SubmittingPatches and elsewhere regarding submitting Linux
Linux kernel patches. kernel patches.
- Builds cleanly with applicable or modified CONFIG options =y, =m, and =n. 1: Builds cleanly with applicable or modified CONFIG options =y, =m, and
No gcc warnings/errors, no linker warnings/errors. =n. No gcc warnings/errors, no linker warnings/errors.
- Passes allnoconfig, allmodconfig 2: Passes allnoconfig, allmodconfig
- Builds on multiple CPU arch-es by using local cross-compile tools 3: Builds on multiple CPU architectures by using local cross-compile tools
or something like PLM at OSDL. or something like PLM at OSDL.
- ppc64 is a good architecture for cross-compilation checking because it 4: ppc64 is a good architecture for cross-compilation checking because it
tends to use `unsigned long' for 64-bit quantities. tends to use `unsigned long' for 64-bit quantities.
- Matches kernel coding style(!) 5: Matches kernel coding style(!)
- Any new or modified CONFIG options don't muck up the config menu. 6: Any new or modified CONFIG options don't muck up the config menu.
- All new Kconfig options have help text. 7: All new Kconfig options have help text.
- Has been carefully reviewed with respect to relevant Kconfig 8: Has been carefully reviewed with respect to relevant Kconfig
combinations. This is very hard to get right with testing -- combinations. This is very hard to get right with testing -- brainpower
brainpower pays off here. pays off here.
- Check cleanly with sparse. 9: Check cleanly with sparse.
- Use 'make checkstack' and 'make namespacecheck' and fix any 10: Use 'make checkstack' and 'make namespacecheck' and fix any problems
problems that they find. Note: checkstack does not point out that they find. Note: checkstack does not point out problems explicitly,
problems explicitly, but any one function that uses more than but any one function that uses more than 512 bytes on the stack is a
512 bytes on the stack is a candidate for change. candidate for change.
- Include kernel-doc to document global kernel APIs. (Not required 11: Include kernel-doc to document global kernel APIs. (Not required for
for static functions, but OK there also.) Use 'make htmldocs' static functions, but OK there also.) Use 'make htmldocs' or 'make
or 'make mandocs' to check the kernel-doc and fix any issues. mandocs' to check the kernel-doc and fix any issues.
- Has been tested with CONFIG_PREEMPT, CONFIG_DEBUG_PREEMPT, 12: Has been tested with CONFIG_PREEMPT, CONFIG_DEBUG_PREEMPT,
CONFIG_DEBUG_SLAB, CONFIG_DEBUG_PAGEALLOC, CONFIG_DEBUG_MUTEXES, CONFIG_DEBUG_SLAB, CONFIG_DEBUG_PAGEALLOC, CONFIG_DEBUG_MUTEXES,
CONFIG_DEBUG_SPINLOCK, CONFIG_DEBUG_SPINLOCK_SLEEP all simultaneously CONFIG_DEBUG_SPINLOCK, CONFIG_DEBUG_SPINLOCK_SLEEP all simultaneously
enabled. enabled.
- Has been build- and runtime tested with and without CONFIG_SMP and 13: Has been build- and runtime tested with and without CONFIG_SMP and
CONFIG_PREEMPT. CONFIG_PREEMPT.
- If the patch affects IO/Disk, etc: has been tested with and without 14: If the patch affects IO/Disk, etc: has been tested with and without
CONFIG_LBD. CONFIG_LBD.
15: All codepaths have been exercised with all lockdep features enabled.
2006-APR-27 16: All new /proc entries are documented under Documentation/
17: All new kernel boot parameters are documented in
Documentation/kernel-parameters.txt.
18: All new module parameters are documented with MODULE_PARM_DESC()