adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 12:16:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

[PATCH] ide: remove dead code from flagged_taskfile()

Browse source 
flagged_taskfile() is called from execute_drive_cmd()
(the only user) only if args->tf_out_flags.all != 0.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
This commit is contained in:
Bartlomiej Zolnierkiewicz 2005-11-19 22:17:55 +01:00
parent c0bc113373
commit e07bc70964
2 changed files with 7 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
drivers/ide/ide-taskfile.c
View file

@ -773,19 +773,13 @@ ide_startstop_t flagged_taskfile (ide_drive_t *drive, ide_task_t *task)
} }
/* /*
* (ks) Check taskfile in/out flags. * (ks) Check taskfile in flags.
* If set, then execute as it is defined. * If set, then execute as it is defined.
* If not set, then define default settings. * If not set, then define default settings.
* The default values are: * The default values are:
* write and read all taskfile registers (except data) * read all taskfile registers (except data)
* write and read the hob registers (sector,nsector,lcyl,hcyl) * read the hob registers (sector, nsector, lcyl, hcyl)
*/ */
if (task->tf_out_flags.all == 0) {
task->tf_out_flags.all = IDE_TASKFILE_STD_OUT_FLAGS;
if (drive->addressing == 1)
task->tf_out_flags.all |= (IDE_HOB_STD_OUT_FLAGS << 8);
}
if (task->tf_in_flags.all == 0) { if (task->tf_in_flags.all == 0) {
task->tf_in_flags.all = IDE_TASKFILE_STD_IN_FLAGS; task->tf_in_flags.all = IDE_TASKFILE_STD_IN_FLAGS;
if (drive->addressing == 1) if (drive->addressing == 1)

6
include/linux/hdreg.h
View file

@ -80,10 +80,12 @@
/* /*
* Define standard taskfile in/out register * Define standard taskfile in/out register
*/ */
#define IDE_TASKFILE_STD_OUT_FLAGS 0xFE
#define IDE_TASKFILE_STD_IN_FLAGS 0xFE #define IDE_TASKFILE_STD_IN_FLAGS 0xFE
#define IDE_HOB_STD_OUT_FLAGS 0x3C
#define IDE_HOB_STD_IN_FLAGS 0x3C #define IDE_HOB_STD_IN_FLAGS 0x3C
#ifndef __KERNEL__
#define IDE_TASKFILE_STD_OUT_FLAGS 0xFE
#define IDE_HOB_STD_OUT_FLAGS 0x3C
#endif
typedef unsigned char task_ioreg_t; typedef unsigned char task_ioreg_t;
typedef unsigned long sata_ioreg_t; typedef unsigned long sata_ioreg_t;