adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 19:56:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

trace: better use of stack_trace_enabled for boot up code

Browse source 
Impact: clean up

Andrew Morton suggested to use the stack_tracer_enabled variable
to decide whether or not to start stack tracing on bootup.
This lets us remove the start_stack_trace variable.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Steven Rostedt 2008-12-17 09:43:00 -05:00 committed by Ingo Molnar
parent f38f1d2aa5
commit e05a43b744
1 changed files with 4 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
kernel/trace/trace_stack.c
View file

@ -308,7 +308,7 @@ stack_trace_sysctl(struct ctl_table *table, int write,
mutex_lock(&stack_sysctl_mutex); mutex_lock(&stack_sysctl_mutex);
ret = proc_dointvec(table, write, file, buffer, lenp, ppos); ret = proc_dointvec(table, write, file, buffer, lenp, ppos);
if (ret || !write || if (ret || !write ||
(last_stack_tracer_enabled == stack_tracer_enabled)) (last_stack_tracer_enabled == stack_tracer_enabled))
@ -326,11 +326,10 @@ stack_trace_sysctl(struct ctl_table *table, int write,
return ret; return ret;
} }
static int start_stack_trace __initdata;
static __init int enable_stacktrace(char *str) static __init int enable_stacktrace(char *str)
{ {
start_stack_trace = 1; stack_tracer_enabled = 1;
last_stack_tracer_enabled = 1;
return 1; return 1;
} }
__setup("stacktrace", enable_stacktrace); __setup("stacktrace", enable_stacktrace);
@ -352,10 +351,8 @@ static __init int stack_trace_init(void)
if (!entry) if (!entry)
pr_warning("Could not create debugfs 'stack_trace' entry\n"); pr_warning("Could not create debugfs 'stack_trace' entry\n");
if (start_stack_trace) { if (stack_tracer_enabled)
register_ftrace_function(&trace_ops); register_ftrace_function(&trace_ops);
stack_tracer_enabled = 1;
}
return 0; return 0;
} }