mirror of
https://github.com/adulau/aha.git
synced 2024-12-28 11:46:19 +00:00
Documentation: prune redundant SubmitChecklist items
Kernel style is mentioned twice, and the git apply trick is a bit redundant given the checkpatch.pl recommendation (which also checks for bad whitespace). Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Cc: "Randy.Dunlap" <rdunlap@xenotime.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
064d9efe94
commit
df24d9a6a9
1 changed files with 5 additions and 11 deletions
|
@ -20,7 +20,11 @@ kernel patches.
|
||||||
4: ppc64 is a good architecture for cross-compilation checking because it
|
4: ppc64 is a good architecture for cross-compilation checking because it
|
||||||
tends to use `unsigned long' for 64-bit quantities.
|
tends to use `unsigned long' for 64-bit quantities.
|
||||||
|
|
||||||
5: Matches kernel coding style(!)
|
5: Check your patch for general style as detailed in
|
||||||
|
Documentation/CodingStyle. Check for trivial violations with the
|
||||||
|
patch style checker prior to submission (scripts/checkpatch.pl).
|
||||||
|
You should be able to justify all violations that remain in
|
||||||
|
your patch.
|
||||||
|
|
||||||
6: Any new or modified CONFIG options don't muck up the config menu.
|
6: Any new or modified CONFIG options don't muck up the config menu.
|
||||||
|
|
||||||
|
@ -79,13 +83,3 @@ kernel patches.
|
||||||
23: Tested after it has been merged into the -mm patchset to make sure
|
23: Tested after it has been merged into the -mm patchset to make sure
|
||||||
that it still works with all of the other queued patches and various
|
that it still works with all of the other queued patches and various
|
||||||
changes in the VM, VFS, and other subsystems.
|
changes in the VM, VFS, and other subsystems.
|
||||||
|
|
||||||
24: Avoid whitespace damage such as indenting with spaces or whitespace
|
|
||||||
at the end of lines. You can test this by feeding the patch to
|
|
||||||
"git apply --check --whitespace=error-all"
|
|
||||||
|
|
||||||
25: Check your patch for general style as detailed in
|
|
||||||
Documentation/CodingStyle. Check for trivial violations with the
|
|
||||||
patch style checker prior to submission (scripts/checkpatch.pl).
|
|
||||||
You should be able to justify all violations that remain in
|
|
||||||
your patch.
|
|
||||||
|
|
Loading…
Reference in a new issue