adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 03:06:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

fs/char_dev.c: remove useless loop

Browse source 
There are two useless lines in fs/char_dev.c.

In register_chrdev there is a loop to change all '/' into '!' in the
kernel object name.
This code is useless as the same substitution is in kobject_set_name_vargs in
lib/kobject.c:
228         /* ewww... some of these buggers have '/' in the name ... */
229         while ((s = strchr(kobj->name, '/')))
230                 s[0] = '!';

kobject_set_name_vargs is called by kobject_set_name.
kobject_set_name is called just above the useless loop.

[hidave.darkstar@gmail.com: fix warning, remove the unused char *s]
Signed-off-by: Renzo Davoli <renzo@cs.unibo.it>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Dave Young <hidave.darkstar@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Renzo Davoli 2009-09-23 15:57:10 -07:00 committed by Linus Torvalds
parent bb521c5de0
commit dd5d81f326
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
fs/char_dev.c
View file

@ -264,7 +264,6 @@ int __register_chrdev(unsigned int major, unsigned int baseminor,
{ {
struct char_device_struct *cd; struct char_device_struct *cd;
struct cdev *cdev; struct cdev *cdev;
char *s;
int err = -ENOMEM; int err = -ENOMEM;
cd = __register_chrdev_region(major, baseminor, count, name); cd = __register_chrdev_region(major, baseminor, count, name);
@ -278,8 +277,6 @@ int __register_chrdev(unsigned int major, unsigned int baseminor,
cdev->owner = fops->owner; cdev->owner = fops->owner;
cdev->ops = fops; cdev->ops = fops;
kobject_set_name(&cdev->kobj, "%s", name); kobject_set_name(&cdev->kobj, "%s", name);
for (s = strchr(kobject_name(&cdev->kobj),'/'); s; s = strchr(s, '/'))
*s = '!';
err = cdev_add(cdev, MKDEV(cd->major, baseminor), count); err = cdev_add(cdev, MKDEV(cd->major, baseminor), count);
if (err) if (err)