adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

cpuset: two minor code-cleanups

Browse source 
In cpuset_update_task_memory_state() local variable struct task_struct
*tsk = current;

And local variable tsk is used 14 times and statement task_cs(tsk) is used
twice in this function.  So using task_cs(tsk) instead of task_cs(current)
is better for readability.

And "(struct cgroup_scanner *)&scan" is not good for readability also.
(and "container_of" is used in cpuset_do_move_task(), not
"(cpuset_hotplug_scanner *)scan")

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Paul Menage <menage@google.com>
Cc: Paul Jackson <pj@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Lai Jiangshan 2008-07-25 01:47:25 -07:00 committed by Linus Torvalds
parent 0241248377
commit da5ef6bb96
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
kernel/cpuset.c
View file

@ -365,7 +365,7 @@ void cpuset_update_task_memory_state(void)
my_cpusets_mem_gen = top_cpuset.mems_generation; my_cpusets_mem_gen = top_cpuset.mems_generation;
} else { } else {
rcu_read_lock(); rcu_read_lock();
my_cpusets_mem_gen = task_cs(current)->mems_generation; my_cpusets_mem_gen = task_cs(tsk)->mems_generation;
rcu_read_unlock(); rcu_read_unlock();
} }
@ -1777,7 +1777,7 @@ static void move_member_tasks_to_cpuset(struct cpuset *from, struct cpuset *to)
scan.scan.heap = NULL; scan.scan.heap = NULL;
scan.to = to->css.cgroup; scan.to = to->css.cgroup;
if (cgroup_scan_tasks((struct cgroup_scanner *)&scan)) if (cgroup_scan_tasks(&scan.scan))
printk(KERN_ERR "move_member_tasks_to_cpuset: " printk(KERN_ERR "move_member_tasks_to_cpuset: "
"cgroup_scan_tasks failed\n"); "cgroup_scan_tasks failed\n");
} }