adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 19:56:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

nbd: use list_for_each_entry_safe to make it more consolidated and readable

Browse source 
Thus the traverse of the loop may delete nodes, use the safe version.

Signed-off-by: Denis Cheng <crquan@gmail.com>
Cc: Paul Clements <paul.clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Denis Cheng 2007-10-16 23:26:14 -07:00 committed by Linus Torvalds
parent 04fc8bbcf5
commit d2c9740b49
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/block/nbd.c
View file

@ -233,8 +233,7 @@ error_out:
static struct request *nbd_find_request(struct nbd_device *lo, char *handle) static struct request *nbd_find_request(struct nbd_device *lo, char *handle)
{ {
struct request *req; struct request *req, *tmp;
struct list_head *tmp;
struct request *xreq; struct request *xreq;
int err; int err;
@ -245,8 +244,7 @@ static struct request *nbd_find_request(struct nbd_device *lo, char *handle)
goto out; goto out;
spin_lock(&lo->queue_lock); spin_lock(&lo->queue_lock);
list_for_each(tmp, &lo->queue_head) { list_for_each_entry_safe(req, tmp, &lo->queue_head, queuelist) {
req = list_entry(tmp, struct request, queuelist);
if (req != xreq) if (req != xreq)
continue; continue;
list_del_init(&req->queuelist); list_del_init(&req->queuelist);