adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

dmaengine: fix dmatest to verify minimum transfer length and test buffer size

Browse source 
Transfers and the test buffer have to be at least align bytes long.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
Guennadi Liakhovetski 2009-12-04 19:44:48 +01:00 committed by Dan Williams
parent ddb4f0f0e0
commit cfe4f2751e
1 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
drivers/dma/dmatest.c
View file

@ -298,10 +298,6 @@ static int dmatest_func(void *data)
total_tests++; total_tests++;
len = dmatest_random() % test_buf_size + 1;
src_off = dmatest_random() % (test_buf_size - len + 1);
dst_off = dmatest_random() % (test_buf_size - len + 1);
/* honor alignment restrictions */ /* honor alignment restrictions */
if (thread->type == DMA_MEMCPY) if (thread->type == DMA_MEMCPY)
align = dev->copy_align; align = dev->copy_align;
@ -310,7 +306,19 @@ static int dmatest_func(void *data)
else if (thread->type == DMA_PQ) else if (thread->type == DMA_PQ)
align = dev->pq_align; align = dev->pq_align;
if (1 << align > test_buf_size) {
pr_err("%u-byte buffer too small for %d-byte alignment\n",
test_buf_size, 1 << align);
break;
}
len = dmatest_random() % test_buf_size + 1;
len = (len >> align) << align; len = (len >> align) << align;
if (!len)
len = 1 << align;
src_off = dmatest_random() % (test_buf_size - len + 1);
dst_off = dmatest_random() % (test_buf_size - len + 1);
src_off = (src_off >> align) << align; src_off = (src_off >> align) << align;
dst_off = (dst_off >> align) << align; dst_off = (dst_off >> align) << align;