dnotify: do not bother to lock entry->lock when reading mask

entry->lock is needed to make sure entry->mask does not change while
manipulating it.  In dnotify_should_send_event() we don't care if we get an
old or a new mask value out of this entry so there is no point it taking
the lock.

Signed-off-by: Eric Paris <eparis@redhat.com>
This commit is contained in:
Eric Paris 2009-06-11 11:09:47 -04:00
parent 5ac697b793
commit ce61856bd2

View file

@ -153,9 +153,8 @@ static bool dnotify_should_send_event(struct fsnotify_group *group,
if (!entry)
return false;
spin_lock(&entry->lock);
send = (mask & entry->mask);
spin_unlock(&entry->lock);
fsnotify_put_mark(entry); /* matches fsnotify_find_mark_entry */
return send;