adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 12:16:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

[IPV6]: Eliminate difference in actions of sysctl and proc handler for conf.all.forwarding

Browse source 
The only difference in this case is that updating all.forwarding
causes the update in default.forwarding when done via proc, but
not via the system call.

Besides, this consolidates a good portion of code.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pavel Emelyanov 2007-12-05 01:50:24 -08:00 committed by David S. Miller
parent 68dd299bc8
commit c8fecf2242
1 changed files with 20 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
net/ipv6/addrconf.c
View file

@ -476,6 +476,21 @@ static void addrconf_forward_change(void)
} }
read_unlock(&dev_base_lock); read_unlock(&dev_base_lock);
} }
static void addrconf_fixup_forwarding(struct ctl_table *table, int *p, int old)
{
if (p == &ipv6_devconf_dflt.forwarding)
return;
if (p == &ipv6_devconf.forwarding) {
ipv6_devconf_dflt.forwarding = ipv6_devconf.forwarding;
addrconf_forward_change();
} else if ((!*p) ^ (!old))
dev_forward_change((struct inet6_dev *)table->extra1);
if (*p)
rt6_purge_dflt_routers();
}
#endif #endif
/* Nobody refers to this ifaddr, destroy it */ /* Nobody refers to this ifaddr, destroy it */
@ -3771,22 +3786,8 @@ int addrconf_sysctl_forward(ctl_table *ctl, int write, struct file * filp,
ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos); ret = proc_dointvec(ctl, write, filp, buffer, lenp, ppos);
if (write && valp != &ipv6_devconf_dflt.forwarding) { if (write)
if (valp != &ipv6_devconf.forwarding) { addrconf_fixup_forwarding(ctl, valp, val);
if ((!*valp) ^ (!val)) {
struct inet6_dev *idev = (struct inet6_dev *)ctl->extra1;
if (idev == NULL)
return ret;
dev_forward_change(idev);
}
} else {
ipv6_devconf_dflt.forwarding = ipv6_devconf.forwarding;
addrconf_forward_change();
}
if (*valp)
rt6_purge_dflt_routers();
}
return ret; return ret;
} }
@ -3797,6 +3798,7 @@ static int addrconf_sysctl_forward_strategy(ctl_table *table,
void __user *newval, size_t newlen) void __user *newval, size_t newlen)
{ {
int *valp = table->data; int *valp = table->data;
int val = *valp;
int new; int new;
if (!newval || !newlen) if (!newval || !newlen)
@ -3821,26 +3823,8 @@ static int addrconf_sysctl_forward_strategy(ctl_table *table,
} }
} }
if (valp != &ipv6_devconf_dflt.forwarding) { *valp = new;
if (valp != &ipv6_devconf.forwarding) { addrconf_fixup_forwarding(table, valp, val);
struct inet6_dev *idev = (struct inet6_dev *)table->extra1;
int changed;
if (unlikely(idev == NULL))
return -ENODEV;
changed = (!*valp) ^ (!new);
*valp = new;
if (changed)
dev_forward_change(idev);
} else {
*valp = new;
addrconf_forward_change();
}
if (*valp)
rt6_purge_dflt_routers();
} else
*valp = new;
return 1; return 1;
} }