adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 12:16:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

rfkill: remove deprecated state constants

Browse source 
I only did superficial review, but these constants are stupid
to have and without proper warnings nobody will review the
code anyway, no amount of shouting will help.

Also fix wimax to use correct states.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Johannes Berg 2009-03-30 11:32:46 +02:00 committed by John W. Linville
parent f4a11bb0c2
commit c1c6b14b22
4 changed files with 8 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
arch/arm/mach-pxa/tosa-bt.c
View file

@ -38,9 +38,9 @@ static void tosa_bt_off(struct tosa_bt_data *data)
static int tosa_bt_toggle_radio(void *data, enum rfkill_state state) static int tosa_bt_toggle_radio(void *data, enum rfkill_state state)
{ {
pr_info("BT_RADIO going: %s\n", pr_info("BT_RADIO going: %s\n",
state == RFKILL_STATE_ON ? "on" : "off"); state == RFKILL_STATE_UNBLOCKED ? "on" : "off");
if (state == RFKILL_STATE_ON) { if (state == RFKILL_STATE_UNBLOCKED) {
pr_info("TOSA_BT: going ON\n"); pr_info("TOSA_BT: going ON\n");
tosa_bt_on(data); tosa_bt_on(data);
} else { } else {

4
drivers/net/usb/hso.c
View file

@ -2484,7 +2484,7 @@ static int add_net_device(struct hso_device *hso_dev)
static int hso_radio_toggle(void *data, enum rfkill_state state) static int hso_radio_toggle(void *data, enum rfkill_state state)
{ {
struct hso_device *hso_dev = data; struct hso_device *hso_dev = data;
int enabled = (state == RFKILL_STATE_ON); int enabled = (state == RFKILL_STATE_UNBLOCKED);
int rv; int rv;
mutex_lock(&hso_dev->mutex); mutex_lock(&hso_dev->mutex);
@ -2522,7 +2522,7 @@ static void hso_create_rfkill(struct hso_device *hso_dev,
snprintf(rfkn, 20, "hso-%d", snprintf(rfkn, 20, "hso-%d",
interface->altsetting->desc.bInterfaceNumber); interface->altsetting->desc.bInterfaceNumber);
hso_net->rfkill->name = rfkn; hso_net->rfkill->name = rfkn;
hso_net->rfkill->state = RFKILL_STATE_ON; hso_net->rfkill->state = RFKILL_STATE_UNBLOCKED;
hso_net->rfkill->data = hso_dev; hso_net->rfkill->data = hso_dev;
hso_net->rfkill->toggle_radio = hso_radio_toggle; hso_net->rfkill->toggle_radio = hso_radio_toggle;
if (rfkill_register(hso_net->rfkill) < 0) { if (rfkill_register(hso_net->rfkill) < 0) {

8
include/linux/rfkill.h
View file

@ -52,14 +52,6 @@ enum rfkill_state {
RFKILL_STATE_MAX, /* marker for last valid state */ RFKILL_STATE_MAX, /* marker for last valid state */
}; };
/*
* These are DEPRECATED, drivers using them should be verified to
* comply with the rfkill usage guidelines in Documentation/rfkill.txt
* and then converted to use the new names for rfkill_state
*/
#define RFKILL_STATE_OFF RFKILL_STATE_SOFT_BLOCKED
#define RFKILL_STATE_ON RFKILL_STATE_UNBLOCKED
/** /**
* struct rfkill - rfkill control structure. * struct rfkill - rfkill control structure.
* @name: Name of the switch. * @name: Name of the switch.

8
net/wimax/op-rfkill.c
View file

@ -113,7 +113,7 @@ void wimax_report_rfkill_hw(struct wimax_dev *wimax_dev,
if (state != wimax_dev->rf_hw) { if (state != wimax_dev->rf_hw) {
wimax_dev->rf_hw = state; wimax_dev->rf_hw = state;
rfkill_state = state == WIMAX_RF_ON ? rfkill_state = state == WIMAX_RF_ON ?
RFKILL_STATE_OFF : RFKILL_STATE_ON; RFKILL_STATE_UNBLOCKED : RFKILL_STATE_SOFT_BLOCKED;
if (wimax_dev->rf_hw == WIMAX_RF_ON if (wimax_dev->rf_hw == WIMAX_RF_ON
&& wimax_dev->rf_sw == WIMAX_RF_ON) && wimax_dev->rf_sw == WIMAX_RF_ON)
wimax_state = WIMAX_ST_READY; wimax_state = WIMAX_ST_READY;
@ -259,10 +259,10 @@ int wimax_rfkill_toggle_radio(void *data, enum rfkill_state state)
d_fnstart(3, dev, "(wimax_dev %p state %u)\n", wimax_dev, state); d_fnstart(3, dev, "(wimax_dev %p state %u)\n", wimax_dev, state);
switch (state) { switch (state) {
case RFKILL_STATE_ON: case RFKILL_STATE_SOFT_BLOCKED:
rf_state = WIMAX_RF_OFF; rf_state = WIMAX_RF_OFF;
break; break;
case RFKILL_STATE_OFF: case RFKILL_STATE_UNBLOCKED:
rf_state = WIMAX_RF_ON; rf_state = WIMAX_RF_ON;
break; break;
default: default:
@ -361,7 +361,7 @@ int wimax_rfkill_add(struct wimax_dev *wimax_dev)
wimax_dev->rfkill = rfkill; wimax_dev->rfkill = rfkill;
rfkill->name = wimax_dev->name; rfkill->name = wimax_dev->name;
rfkill->state = RFKILL_STATE_OFF; rfkill->state = RFKILL_STATE_UNBLOCKED;
rfkill->data = wimax_dev; rfkill->data = wimax_dev;
rfkill->toggle_radio = wimax_rfkill_toggle_radio; rfkill->toggle_radio = wimax_rfkill_toggle_radio;
rfkill->user_claim_unsupported = 1; rfkill->user_claim_unsupported = 1;