adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 04:06:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

crypto: api - Fix algorithm test race that broke aead initialisation

Browse source 
When we complete a test we'll notify everyone waiting on it, drop
the mutex, and then remove the test larval (after reacquiring the
mutex).  If one of the notified parties tries to register another
algorithm with the same driver name prior to the removal of the
test larval, they will fail with EEXIST as only one algorithm of
a given name can be tested at any time.

This broke the initialisation of aead and givcipher algorithms as
they will register two algorithms with the same driver name, in
sequence.

This patch fixes the problem by marking the larval as dead before
we drop the mutex, and also ignoring all dead or dying algorithms
on the registration path.

Tested-by: Andreas Steffen <andreas.steffen@strongswan.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Herbert Xu 2009-01-28 14:09:59 +11:00
parent 516280e735
commit b8e15992b4
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crypto/algapi.c
View file

@ -149,6 +149,9 @@ static struct crypto_larval *__crypto_register_alg(struct crypto_alg *alg)
if (q == alg) if (q == alg)
goto err; goto err;
if (crypto_is_moribund(q))
continue;
if (crypto_is_larval(q)) { if (crypto_is_larval(q)) {
if (!strcmp(alg->cra_driver_name, q->cra_driver_name)) if (!strcmp(alg->cra_driver_name, q->cra_driver_name))
goto err; goto err;
@ -197,7 +200,7 @@ void crypto_alg_tested(const char *name, int err)
down_write(&crypto_alg_sem); down_write(&crypto_alg_sem);
list_for_each_entry(q, &crypto_alg_list, cra_list) { list_for_each_entry(q, &crypto_alg_list, cra_list) {
if (!crypto_is_larval(q)) if (crypto_is_moribund(q) || !crypto_is_larval(q))
continue; continue;
test = (struct crypto_larval *)q; test = (struct crypto_larval *)q;
@ -210,6 +213,7 @@ void crypto_alg_tested(const char *name, int err)
goto unlock; goto unlock;
found: found:
q->cra_flags |= CRYPTO_ALG_DEAD;
alg = test->adult; alg = test->adult;
if (err || list_empty(&alg->cra_list)) if (err || list_empty(&alg->cra_list))
goto complete; goto complete;