adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

bio: fix __bio_copy_iov() handling of bio->bv_len

Browse source 
The commit c5dec1c303 introduced
__bio_copy_iov() to add bounce support to blk_rq_map_user_iov.

__bio_copy_iov() uses bio->bv_len to copy data for READ commands after
the completion but it doesn't work with a request that partially
completed. SCSI always completes a PC request as a whole but seems
some don't.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: stable@kernel.org
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
FUJITA Tomonori 2008-08-25 20:36:08 +02:00 committed by Jens Axboe
parent 76029ff37f
commit aefcc28a3a
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
fs/bio.c
View file

@ -492,8 +492,8 @@ static struct bio_map_data *bio_alloc_map_data(int nr_segs, int iov_count,
return NULL; return NULL;
} }
static int __bio_copy_iov(struct bio *bio, struct sg_iovec *iov, int iov_count, static int __bio_copy_iov(struct bio *bio, struct bio_vec *iovecs,
int uncopy) struct sg_iovec *iov, int iov_count, int uncopy)
{ {
int ret = 0, i; int ret = 0, i;
struct bio_vec *bvec; struct bio_vec *bvec;
@ -503,7 +503,7 @@ static int __bio_copy_iov(struct bio *bio, struct sg_iovec *iov, int iov_count,
__bio_for_each_segment(bvec, bio, i, 0) { __bio_for_each_segment(bvec, bio, i, 0) {
char *bv_addr = page_address(bvec->bv_page); char *bv_addr = page_address(bvec->bv_page);
unsigned int bv_len = bvec->bv_len; unsigned int bv_len = iovecs[i].bv_len;
while (bv_len && iov_idx < iov_count) { while (bv_len && iov_idx < iov_count) {
unsigned int bytes; unsigned int bytes;
@ -555,7 +555,7 @@ int bio_uncopy_user(struct bio *bio)
struct bio_map_data *bmd = bio->bi_private; struct bio_map_data *bmd = bio->bi_private;
int ret; int ret;
ret = __bio_copy_iov(bio, bmd->sgvecs, bmd->nr_sgvecs, 1); ret = __bio_copy_iov(bio, bmd->iovecs, bmd->sgvecs, bmd->nr_sgvecs, 1);
bio_free_map_data(bmd); bio_free_map_data(bmd);
bio_put(bio); bio_put(bio);
@ -634,7 +634,7 @@ struct bio *bio_copy_user_iov(struct request_queue *q, struct sg_iovec *iov,
* success * success
*/ */
if (!write_to_vm) { if (!write_to_vm) {
ret = __bio_copy_iov(bio, iov, iov_count, 0); ret = __bio_copy_iov(bio, bio->bi_io_vec, iov, iov_count, 0);
if (ret) if (ret)
goto cleanup; goto cleanup;
} }