adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

tty: Fix an ircomm warning and note another bug

Browse source 
Roel Kluin noted that line is unsigned so one test is unneccessary. Also
add a warning for another flaw I noticed while making this change.

Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alan Cox 2009-01-02 13:50:20 +00:00 committed by Linus Torvalds
parent c847d47cb7
commit ad36b88e2d
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/irda/ircomm/ircomm_tty.c
View file

@ -371,9 +371,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp)
IRDA_DEBUG(2, "%s()\n", __func__ ); IRDA_DEBUG(2, "%s()\n", __func__ );
line = tty->index; line = tty->index;
if ((line < 0) || (line >= IRCOMM_TTY_PORTS)) { if (line >= IRCOMM_TTY_PORTS)
return -ENODEV; return -ENODEV;
}
/* Check if instance already exists */ /* Check if instance already exists */
self = hashbin_lock_find(ircomm_tty, line, NULL); self = hashbin_lock_find(ircomm_tty, line, NULL);
@ -405,6 +404,8 @@ static int ircomm_tty_open(struct tty_struct *tty, struct file *filp)
* Force TTY into raw mode by default which is usually what * Force TTY into raw mode by default which is usually what
* we want for IrCOMM and IrLPT. This way applications will * we want for IrCOMM and IrLPT. This way applications will
* not have to twiddle with printcap etc. * not have to twiddle with printcap etc.
*
* Note this is completely usafe and doesn't work properly
*/ */
tty->termios->c_iflag = 0; tty->termios->c_iflag = 0;
tty->termios->c_oflag = 0; tty->termios->c_oflag = 0;