mirror of
https://github.com/adulau/aha.git
synced 2024-12-29 12:16:20 +00:00
unsigned fid->fid cannot be negative
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
This commit is contained in:
parent
1558c62149
commit
9f3e9bbe62
1 changed files with 5 additions and 4 deletions
|
@ -608,7 +608,7 @@ reterr:
|
||||||
|
|
||||||
static struct p9_fid *p9_fid_create(struct p9_client *clnt)
|
static struct p9_fid *p9_fid_create(struct p9_client *clnt)
|
||||||
{
|
{
|
||||||
int err;
|
int ret;
|
||||||
struct p9_fid *fid;
|
struct p9_fid *fid;
|
||||||
unsigned long flags;
|
unsigned long flags;
|
||||||
|
|
||||||
|
@ -617,11 +617,12 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt)
|
||||||
if (!fid)
|
if (!fid)
|
||||||
return ERR_PTR(-ENOMEM);
|
return ERR_PTR(-ENOMEM);
|
||||||
|
|
||||||
fid->fid = p9_idpool_get(clnt->fidpool);
|
ret = p9_idpool_get(clnt->fidpool);
|
||||||
if (fid->fid < 0) {
|
if (fid->fid < 0) {
|
||||||
err = -ENOSPC;
|
ret = -ENOSPC;
|
||||||
goto error;
|
goto error;
|
||||||
}
|
}
|
||||||
|
fid->fid = ret;
|
||||||
|
|
||||||
memset(&fid->qid, 0, sizeof(struct p9_qid));
|
memset(&fid->qid, 0, sizeof(struct p9_qid));
|
||||||
fid->mode = -1;
|
fid->mode = -1;
|
||||||
|
@ -638,7 +639,7 @@ static struct p9_fid *p9_fid_create(struct p9_client *clnt)
|
||||||
|
|
||||||
error:
|
error:
|
||||||
kfree(fid);
|
kfree(fid);
|
||||||
return ERR_PTR(err);
|
return ERR_PTR(ret);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void p9_fid_destroy(struct p9_fid *fid)
|
static void p9_fid_destroy(struct p9_fid *fid)
|
||||||
|
|
Loading…
Reference in a new issue