adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

[PATCH] reiserfs: eliminate minimum window size for bitmap searching

Browse source 
When a file system becomes fragmented (using MythTV, for example), the
bigalloc window searching ends up causing huge performance problems.  In a
file system presented by a user experiencing this bug, the file system was
90% free, but no 32-block free windows existed on the entire file system.
This causes the allocator to scan the entire file system for each 128k
write before backing down to searching for individual blocks.

In the end, finding a contiguous window for all the blocks in a write is an
advantageous special case, but one that can be found naturally when such a
window exists anyway.

This patch removes the bigalloc window searching, and has been proven to
fix the test case described above.

Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Jeff Mahoney 2006-09-30 23:28:45 -07:00 committed by Linus Torvalds
parent 5a2618e6a9
commit 9ea0f9499d
1 changed files with 1 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
fs/reiserfs/bitmap.c
View file

@ -1034,7 +1034,6 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start
b_blocknr_t finish = SB_BLOCK_COUNT(s) - 1;
int passno = 0;
int nr_allocated = 0;
int bigalloc = 0;
determine_prealloc_size(hint);
if (!hint->formatted_node) {
@ -1061,28 +1060,9 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start
hint->preallocate = hint->prealloc_size = 0;
}
/* for unformatted nodes, force large allocations */
bigalloc = amount_needed;
}
do {
/* in bigalloc mode, nr_allocated should stay zero until
* the entire allocation is filled
*/
if (unlikely(bigalloc && nr_allocated)) {
reiserfs_warning(s, "bigalloc is %d, nr_allocated %d\n",
bigalloc, nr_allocated);
/* reset things to a sane value */
bigalloc = amount_needed - nr_allocated;
}
/*
* try pass 0 and pass 1 looking for a nice big
* contiguous allocation. Then reset and look
* for anything you can find.
*/
if (passno == 2 && bigalloc) {
passno = 0;
bigalloc = 0;
}
switch (passno++) {
case 0: /* Search from hint->search_start to end of disk */
start = hint->search_start;
@ -1120,8 +1100,7 @@ static inline int blocknrs_and_prealloc_arrays_from_search_start
new_blocknrs +
nr_allocated,
start, finish,
bigalloc ?
bigalloc : 1,
1,
amount_needed -
nr_allocated,
hint->