adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 11:46:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

[POWERPC] mpic_u3msi: Failed allocation unnoticed

Browse source 
bitmap_find_free_region(), called by mpic_msi_alloc_hwirqs() may return
signed, but hwirq is unsigned.  A failed allocation remains unnoticed.

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Roel Kluin 2008-04-24 09:03:02 +10:00 committed by Paul Mackerras
parent ee1a08f963
commit 9d5f525b86
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/powerpc/sysdev/mpic_u3msi.c
View file

@ -115,17 +115,19 @@ static int u3msi_setup_msi_irqs(struct pci_dev *pdev, int nvec, int type)
struct msi_desc *entry; struct msi_desc *entry;
struct msi_msg msg; struct msi_msg msg;
u64 addr; u64 addr;
int ret;
addr = find_ht_magic_addr(pdev); addr = find_ht_magic_addr(pdev);
msg.address_lo = addr & 0xFFFFFFFF; msg.address_lo = addr & 0xFFFFFFFF;
msg.address_hi = addr >> 32; msg.address_hi = addr >> 32;
list_for_each_entry(entry, &pdev->msi_list, list) { list_for_each_entry(entry, &pdev->msi_list, list) {
hwirq = mpic_msi_alloc_hwirqs(msi_mpic, 1); ret = mpic_msi_alloc_hwirqs(msi_mpic, 1);
if (hwirq < 0) { if (ret < 0) {
pr_debug("u3msi: failed allocating hwirq\n"); pr_debug("u3msi: failed allocating hwirq\n");
return hwirq; return ret;
} }
hwirq = ret;
virq = irq_create_mapping(msi_mpic->irqhost, hwirq); virq = irq_create_mapping(msi_mpic->irqhost, hwirq);
if (virq == NO_IRQ) { if (virq == NO_IRQ) {