adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 03:06:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

kernel: is_current_single_threaded: don't use ->mmap_sem

Browse source 
is_current_single_threaded() can safely miss a freshly forked CLONE_VM
task, but in this case it must not miss its parent. That is why we take
mm->mmap_sem for writing to make sure a thread/task with the same ->mm
can't pass exit_mm() and disappear.

However we can avoid ->mmap_sem and rely on rcu/barriers:

	- if we do not see the exiting parent on thread/process list
	  we see the result of list_del_rcu(), in this case we must
	  also see the result of list_add_rcu() which does wmb().

	- if we do see the parent but its ->mm == NULL, we need rmb()
	  to make sure we can't miss the child.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: James Morris <jmorris@namei.org>
This commit is contained in:
Oleg Nesterov 2009-07-09 23:28:49 +02:00 committed by James Morris
parent 5bb459bb45
commit 967cc53711
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/is_single_threaded.c
View file

@ -22,8 +22,6 @@ bool current_is_single_threaded(void)
struct task_struct *p, *t; struct task_struct *p, *t;
bool ret; bool ret;
might_sleep();
if (atomic_read(&task->signal->live) != 1) if (atomic_read(&task->signal->live) != 1)
return false; return false;
@ -31,7 +29,6 @@ bool current_is_single_threaded(void)
return true; return true;
ret = false; ret = false;
down_write(&mm->mmap_sem);
rcu_read_lock(); rcu_read_lock();
for_each_process(p) { for_each_process(p) {
if (unlikely(p->flags & PF_KTHREAD)) if (unlikely(p->flags & PF_KTHREAD))
@ -45,12 +42,17 @@ bool current_is_single_threaded(void)
goto found; goto found;
if (likely(t->mm)) if (likely(t->mm))
break; break;
/*
* t->mm == NULL. Make sure next_thread/next_task
* will see other CLONE_VM tasks which might be
* forked before exiting.
*/
smp_rmb();
} while_each_thread(p, t); } while_each_thread(p, t);
} }
ret = true; ret = true;
found: found:
rcu_read_unlock(); rcu_read_unlock();
up_write(&mm->mmap_sem);
return ret; return ret;
} }