adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 19:26:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

GFS2: Remove obsolete code in quota.c

Browse source 
There is no point in testing for GLF_DEMOTE here, we might as
well always release the glock at that point.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
This commit is contained in:
Steven Whitehouse 2009-09-11 15:21:56 +01:00
parent cc632e7f93
commit 91094d0fb6
2 changed files with 5 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
fs/gfs2/glock.h
View file

@ -180,15 +180,6 @@ static inline int gfs2_glock_is_held_shrd(struct gfs2_glock *gl)
return gl->gl_state == LM_ST_SHARED; return gl->gl_state == LM_ST_SHARED;
} }
static inline int gfs2_glock_is_blocking(struct gfs2_glock *gl)
{
int ret;
spin_lock(&gl->gl_spin);
ret = test_bit(GLF_DEMOTE, &gl->gl_flags);
spin_unlock(&gl->gl_spin);
return ret;
}
int gfs2_glock_get(struct gfs2_sbd *sdp, int gfs2_glock_get(struct gfs2_sbd *sdp,
u64 number, const struct gfs2_glock_operations *glops, u64 number, const struct gfs2_glock_operations *glops,
int create, struct gfs2_glock **glp); int create, struct gfs2_glock **glp);

13
fs/gfs2/quota.c
View file

@ -843,9 +843,8 @@ restart:
if (force_refresh || qd->qd_qb.qb_magic != cpu_to_be32(GFS2_MAGIC)) { if (force_refresh || qd->qd_qb.qb_magic != cpu_to_be32(GFS2_MAGIC)) {
loff_t pos; loff_t pos;
gfs2_glock_dq_uninit(q_gh); gfs2_glock_dq_uninit(q_gh);
error = gfs2_glock_nq_init(qd->qd_gl, error = gfs2_glock_nq_init(qd->qd_gl, LM_ST_EXCLUSIVE,
LM_ST_EXCLUSIVE, GL_NOCACHE, GL_NOCACHE, q_gh);
q_gh);
if (error) if (error)
return error; return error;
@ -871,11 +870,9 @@ restart:
qlvb->qb_value = cpu_to_be64(q.qu_value); qlvb->qb_value = cpu_to_be64(q.qu_value);
qd->qd_qb = *qlvb; qd->qd_qb = *qlvb;
if (gfs2_glock_is_blocking(qd->qd_gl)) { gfs2_glock_dq_uninit(q_gh);
gfs2_glock_dq_uninit(q_gh); force_refresh = 0;
force_refresh = 0; goto restart;
goto restart;
}
} }
return 0; return 0;