adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 11:16:11 +00:00
Code Issues Projects Releases Packages Wiki Activity

crypto: lrw - Fix big endian support

Browse source 
It turns out that LRW has never worked properly on big endian.
This was never discussed because nobody actually used it that
way.  In fact, it was only discovered when Geert Uytterhoeven
loaded it through tcrypt which failed the test on it.

The fix is straightforward, on big endian the to find the nth
bit we should be grouping them by words instead of bytes.  So
setbit128_bbe should xor with 128 - BITS_PER_LONG instead of
128 - BITS_PER_BYTE == 0x78.

Tested-by: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Herbert Xu 2009-02-17 20:00:11 +08:00
parent d2f8d7ee1a
commit 8eb2dfac41
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
crypto/lrw.c
View file

@ -45,7 +45,13 @@ struct priv {
static inline void setbit128_bbe(void *b, int bit) static inline void setbit128_bbe(void *b, int bit)
{ {
__set_bit(bit ^ 0x78, b); __set_bit(bit ^ (0x80 -
#ifdef __BIG_ENDIAN
BITS_PER_LONG
#else
BITS_PER_BYTE
#endif
), b);
} }
static int setkey(struct crypto_tfm *parent, const u8 *key, static int setkey(struct crypto_tfm *parent, const u8 *key,