adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

sysctl: fix false positives when PROC_SYSCTL=n

Browse source 
Having ->procname but not ->proc_handler is valid when PROC_SYSCTL=n,
people use such combination to reduce ifdefs with non-standard handlers.

Addresses http://bugzilla.kernel.org/show_bug.cgi?id=14408

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Reported-by: Peter Teoh <htmldeveloper@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alexey Dobriyan 2009-10-26 16:50:07 -07:00 committed by Linus Torvalds
parent 115a57c5b3
commit 8c85dd8730
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
kernel/sysctl_check.c
View file

@ -1521,7 +1521,7 @@ int sysctl_check_table(struct nsproxy *namespaces, struct ctl_table *table)
if (!table->ctl_name && table->strategy) if (!table->ctl_name && table->strategy)
set_fail(&fail, table, "Strategy without ctl_name"); set_fail(&fail, table, "Strategy without ctl_name");
#endif #endif
#ifdef CONFIG_PROC_FS #ifdef CONFIG_PROC_SYSCTL
if (table->procname && !table->proc_handler) if (table->procname && !table->proc_handler)
set_fail(&fail, table, "No proc_handler"); set_fail(&fail, table, "No proc_handler");
#endif #endif