adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 12:16:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

tracing/ftrace: Fix to check create_event_dir() when adding new events

Browse source 
Check result of event_create_dir() and add ftrace_event_call to
ftrace_events list only if it is succeeded. Thanks to Li for pointing
it out.

Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Acked-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: Jim Keniston <jkenisto@us.ibm.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Frank Ch. Eigler <fche@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jason Baron <jbaron@redhat.com>
Cc: K.Prasad <prasad@linux.vnet.ibm.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <20090925182054.10157.55219.stgit@omoto>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
This commit is contained in:
Masami Hiramatsu 2009-09-25 11:20:54 -07:00 committed by Frederic Weisbecker
parent c0b11d3af1
commit 88f70d7590
1 changed files with 14 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
kernel/trace/trace_events.c
View file

@ -957,12 +957,12 @@ static int __trace_add_event_call(struct ftrace_event_call *call)
if (!d_events) if (!d_events)
return -ENOENT; return -ENOENT;
list_add(&call->list, &ftrace_events);
ret = event_create_dir(call, d_events, &ftrace_event_id_fops, ret = event_create_dir(call, d_events, &ftrace_event_id_fops,
&ftrace_enable_fops, &ftrace_event_filter_fops, &ftrace_enable_fops, &ftrace_event_filter_fops,
&ftrace_event_format_fops); &ftrace_event_format_fops);
if (ret < 0) if (!ret)
list_del(&call->list); list_add(&call->list, &ftrace_events);
return ret; return ret;
} }
@ -1124,10 +1124,11 @@ static void trace_module_add_events(struct module *mod)
return; return;
} }
call->mod = mod; call->mod = mod;
list_add(&call->list, &ftrace_events); ret = event_create_dir(call, d_events,
event_create_dir(call, d_events,
&file_ops->id, &file_ops->enable, &file_ops->id, &file_ops->enable,
&file_ops->filter, &file_ops->format); &file_ops->filter, &file_ops->format);
if (!ret)
list_add(&call->list, &ftrace_events);
} }
} }
@ -1267,10 +1268,12 @@ static __init int event_trace_init(void)
continue; continue;
} }
} }
list_add(&call->list, &ftrace_events); ret = event_create_dir(call, d_events, &ftrace_event_id_fops,
event_create_dir(call, d_events, &ftrace_event_id_fops, &ftrace_enable_fops,
&ftrace_enable_fops, &ftrace_event_filter_fops, &ftrace_event_filter_fops,
&ftrace_event_format_fops); &ftrace_event_format_fops);
if (!ret)
list_add(&call->list, &ftrace_events);
} }
while (true) { while (true) {