adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 19:26:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

NET: cassini, fix lock imbalance

Browse source 
Stanse found that one error path in cas_open omits to unlock pm_mutex.
Fix that.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jiri Slaby 2009-11-05 23:14:29 +00:00 committed by David S. Miller
parent 2b2072e902
commit 87d75b5241
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
drivers/net/cassini.c
View file

@ -4342,11 +4342,11 @@ static int cas_open(struct net_device *dev)
cas_unlock_all_restore(cp, flags); cas_unlock_all_restore(cp, flags);
} }
err = -ENOMEM;
if (cas_tx_tiny_alloc(cp) < 0) if (cas_tx_tiny_alloc(cp) < 0)
return -ENOMEM; goto err_unlock;
/* alloc rx descriptors */ /* alloc rx descriptors */
err = -ENOMEM;
if (cas_alloc_rxds(cp) < 0) if (cas_alloc_rxds(cp) < 0)
goto err_tx_tiny; goto err_tx_tiny;
@ -4386,6 +4386,7 @@ err_spare:
cas_free_rxds(cp); cas_free_rxds(cp);
err_tx_tiny: err_tx_tiny:
cas_tx_tiny_free(cp); cas_tx_tiny_free(cp);
err_unlock:
mutex_unlock(&cp->pm_mutex); mutex_unlock(&cp->pm_mutex);
return err; return err;
} }