adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-27 19:26:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Staging: agnx: Move a dereference below a NULL test

Browse source 
If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: YanBo <dreamfly281@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Julia Lawall 2008-12-19 18:11:01 +01:00 committed by Greg Kroah-Hartman
parent 4ed4f41c1b
commit 6bf676723a
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/staging/agnx/pci.c
View file

@ -434,11 +434,12 @@ static struct ieee80211_ops agnx_ops = {
static void __devexit agnx_pci_remove(struct pci_dev *pdev) static void __devexit agnx_pci_remove(struct pci_dev *pdev)
{ {
struct ieee80211_hw *dev = pci_get_drvdata(pdev); struct ieee80211_hw *dev = pci_get_drvdata(pdev);
struct agnx_priv *priv = dev->priv; struct agnx_priv *priv;
AGNX_TRACE; AGNX_TRACE;
if (!dev) if (!dev)
return; return;
priv = dev->priv;
ieee80211_unregister_hw(dev); ieee80211_unregister_hw(dev);
pci_iounmap(pdev, priv->ctl); pci_iounmap(pdev, priv->ctl);
pci_iounmap(pdev, priv->data); pci_iounmap(pdev, priv->data);