adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

checkpatch: struct seq_operations should normally be const

Browse source 
In the general use case struct seq_operations should be a const object.
Check for and warn where it is not.

Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Andy Whitcroft 2009-01-15 13:51:07 -08:00 committed by Linus Torvalds
parent 3966778236
commit 6903ffb225
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
scripts/checkpatch.pl
View file

@ -2527,9 +2527,10 @@ sub process {
WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
} }
# check for struct file_operations, ensure they are const. # check for struct file_operations, ensure they are const.
if ($line =~ /\bstruct\s+file_operations\b/ && if ($line !~ /\bconst\b/ &&
$line !~ /\bconst\b/) { $line =~ /\bstruct\s+(file_operations|seq_operations)\b/) {
WARN("struct file_operations should normally be const\n" . $herecurr); WARN("struct $1 should normally be const\n" .
$herecurr);
} }
# use of NR_CPUS is usually wrong # use of NR_CPUS is usually wrong