adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

kprobes: fix error checking of batch registration

Browse source 
Fix error checking routine to catch an error which occurs in first
__register_*probe().

Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Cc: Jim Keniston <jkenisto@us.ibm.com>
Cc: David Miller <davem@davemloft.net>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Masami Hiramatsu 2008-06-12 15:21:35 -07:00 committed by Linus Torvalds
parent 24aac480e7
commit 67dddaad5d
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
kernel/kprobes.c
View file

@ -699,8 +699,9 @@ static int __register_kprobes(struct kprobe **kps, int num,
return -EINVAL; return -EINVAL;
for (i = 0; i < num; i++) { for (i = 0; i < num; i++) {
ret = __register_kprobe(kps[i], called_from); ret = __register_kprobe(kps[i], called_from);
if (ret < 0 && i > 0) { if (ret < 0) {
unregister_kprobes(kps, i); if (i > 0)
unregister_kprobes(kps, i);
break; break;
} }
} }
@ -776,8 +777,9 @@ static int __register_jprobes(struct jprobe **jps, int num,
jp->kp.break_handler = longjmp_break_handler; jp->kp.break_handler = longjmp_break_handler;
ret = __register_kprobe(&jp->kp, called_from); ret = __register_kprobe(&jp->kp, called_from);
} }
if (ret < 0 && i > 0) { if (ret < 0) {
unregister_jprobes(jps, i); if (i > 0)
unregister_jprobes(jps, i);
break; break;
} }
} }
@ -920,8 +922,9 @@ static int __register_kretprobes(struct kretprobe **rps, int num,
return -EINVAL; return -EINVAL;
for (i = 0; i < num; i++) { for (i = 0; i < num; i++) {
ret = __register_kretprobe(rps[i], called_from); ret = __register_kretprobe(rps[i], called_from);
if (ret < 0 && i > 0) { if (ret < 0) {
unregister_kretprobes(rps, i); if (i > 0)
unregister_kretprobes(rps, i);
break; break;
} }
} }