mirror of
https://github.com/adulau/aha.git
synced 2024-12-26 18:56:14 +00:00
kbuild/headers_check: refine extern check
'extern' checking information is not clear, refine it. Plus, fix a comment. Signed-off-by: WANG Cong <amwang@redhat.com> [sam: redid the extern error message] Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
This commit is contained in:
parent
7211b8b902
commit
67b7ebe091
1 changed files with 7 additions and 5 deletions
|
@ -2,7 +2,7 @@
|
||||||
#
|
#
|
||||||
# headers_check.pl execute a number of trivial consistency checks
|
# headers_check.pl execute a number of trivial consistency checks
|
||||||
#
|
#
|
||||||
# Usage: headers_check.pl dir [files...]
|
# Usage: headers_check.pl dir arch [files...]
|
||||||
# dir: dir to look for included files
|
# dir: dir to look for included files
|
||||||
# arch: architecture
|
# arch: architecture
|
||||||
# files: list of files to check
|
# files: list of files to check
|
||||||
|
@ -37,7 +37,7 @@ foreach my $file (@files) {
|
||||||
&check_include();
|
&check_include();
|
||||||
&check_asm_types();
|
&check_asm_types();
|
||||||
&check_sizetypes();
|
&check_sizetypes();
|
||||||
&check_prototypes();
|
&check_declarations();
|
||||||
# Dropped for now. Too much noise &check_config();
|
# Dropped for now. Too much noise &check_config();
|
||||||
}
|
}
|
||||||
close FH;
|
close FH;
|
||||||
|
@ -61,10 +61,12 @@ sub check_include
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
sub check_prototypes
|
sub check_declarations
|
||||||
{
|
{
|
||||||
if ($line =~ m/^\s*extern\b/) {
|
if ($line =~m/^\s*extern\b/) {
|
||||||
printf STDERR "$filename:$lineno: extern's make no sense in userspace\n";
|
printf STDERR "$filename:$lineno: " .
|
||||||
|
"userspace cannot call function or variable " .
|
||||||
|
"defined in the kernel\n";
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue