adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-29 04:06:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

af_iucv: Free iucv path/socket in path_pending callback

Browse source 
Free iucv path after iucv_path_sever() calls in iucv_callback_connreq()
(path_pending() iucv callback).
If iucv_path_accept() fails, free path and free/kill newly created socket.

Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Hendrik Brueckner 2009-01-05 18:08:23 -08:00 committed by David S. Miller
parent 18becbc547
commit 65dbd7c277
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/iucv/af_iucv.c
View file

@ -1042,12 +1042,14 @@ static int iucv_callback_connreq(struct iucv_path *path,
ASCEBC(user_data, sizeof(user_data)); ASCEBC(user_data, sizeof(user_data));
if (sk->sk_state != IUCV_LISTEN) { if (sk->sk_state != IUCV_LISTEN) {
err = iucv_path_sever(path, user_data); err = iucv_path_sever(path, user_data);
iucv_path_free(path);
goto fail; goto fail;
} }
/* Check for backlog size */ /* Check for backlog size */
if (sk_acceptq_is_full(sk)) { if (sk_acceptq_is_full(sk)) {
err = iucv_path_sever(path, user_data); err = iucv_path_sever(path, user_data);
iucv_path_free(path);
goto fail; goto fail;
} }
@ -1055,6 +1057,7 @@ static int iucv_callback_connreq(struct iucv_path *path,
nsk = iucv_sock_alloc(NULL, SOCK_STREAM, GFP_ATOMIC); nsk = iucv_sock_alloc(NULL, SOCK_STREAM, GFP_ATOMIC);
if (!nsk) { if (!nsk) {
err = iucv_path_sever(path, user_data); err = iucv_path_sever(path, user_data);
iucv_path_free(path);
goto fail; goto fail;
} }
@ -1078,6 +1081,8 @@ static int iucv_callback_connreq(struct iucv_path *path,
err = iucv_path_accept(path, &af_iucv_handler, nuser_data, nsk); err = iucv_path_accept(path, &af_iucv_handler, nuser_data, nsk);
if (err) { if (err) {
err = iucv_path_sever(path, user_data); err = iucv_path_sever(path, user_data);
iucv_path_free(path);
iucv_sock_kill(nsk);
goto fail; goto fail;
} }