adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-28 03:36:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

net: Cleanup redundant tests on unsigned

Browse source 
optlen is unsigned so the `< 0' test is never true.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
roel kluin 2009-10-23 05:59:21 +00:00 committed by David S. Miller
parent 091bb8ab51
commit 65a1c4fffa
3 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
net/can/raw.c
View file

@ -424,8 +424,6 @@ static int raw_setsockopt(struct socket *sock, int level, int optname,
if (level != SOL_CAN_RAW) if (level != SOL_CAN_RAW)
return -EINVAL; return -EINVAL;
if (optlen < 0)
return -EINVAL;
switch (optname) { switch (optname) {

3
net/compat.c
View file

@ -390,9 +390,6 @@ asmlinkage long compat_sys_setsockopt(int fd, int level, int optname,
int err; int err;
struct socket *sock; struct socket *sock;
if (optlen < 0)
return -EINVAL;
if ((sock = sockfd_lookup(fd, &err))!=NULL) if ((sock = sockfd_lookup(fd, &err))!=NULL)
{ {
err = security_socket_setsockopt(sock,level,optname); err = security_socket_setsockopt(sock,level,optname);

2
net/ipv4/ip_sockglue.c
View file

@ -480,7 +480,7 @@ static int do_ip_setsockopt(struct sock *sk, int level,
case IP_OPTIONS: case IP_OPTIONS:
{ {
struct ip_options *opt = NULL; struct ip_options *opt = NULL;
if (optlen > 40 || optlen < 0) if (optlen > 40)
goto e_inval; goto e_inval;
err = ip_options_get_from_user(sock_net(sk), &opt, err = ip_options_get_from_user(sock_net(sk), &opt,
optval, optlen); optval, optlen);