adulau/aha
1
0
Fork 0
mirror of https://github.com/adulau/aha.git synced 2024-12-30 12:46:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

RDMA/ucm: BKL is not needed for ib_ucm_open()

Browse source 
Remove explicit cycle_kernel_lock() call and document why the code is safe.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
Roland Dreier 2008-07-24 20:36:59 -07:00
parent f7a6117ee5
commit 5ba18b186c
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/infiniband/core/ucm.c
View file

@ -43,7 +43,6 @@
#include <linux/cdev.h> #include <linux/cdev.h>
#include <linux/idr.h> #include <linux/idr.h>
#include <linux/mutex.h> #include <linux/mutex.h>
#include <linux/smp_lock.h>
#include <asm/uaccess.h> #include <asm/uaccess.h>
@ -1154,11 +1153,18 @@ static unsigned int ib_ucm_poll(struct file *filp,
return mask; return mask;
} }
/*
* ib_ucm_open() does not need the BKL:
*
* - no global state is referred to;
* - there is no ioctl method to race against;
* - no further module initialization is required for open to work
* after the device is registered.
*/
static int ib_ucm_open(struct inode *inode, struct file *filp) static int ib_ucm_open(struct inode *inode, struct file *filp)
{ {
struct ib_ucm_file *file; struct ib_ucm_file *file;
cycle_kernel_lock();
file = kmalloc(sizeof(*file), GFP_KERNEL); file = kmalloc(sizeof(*file), GFP_KERNEL);
if (!file) if (!file)
return -ENOMEM; return -ENOMEM;