mirror of
https://github.com/adulau/aha.git
synced 2024-12-27 19:26:25 +00:00
expand some comments (d_path / seq_path)
Explain that you really need to use the return value of d_path rather than the buffer you passed into it. Also fix the comment for seq_path(), the function arguments changed recently but the comment hadn't been updated in sync. Signed-off-by: Arjan van de Ven <arjan@linux.intel.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Christoph Hellwig <hch@lst.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
parent
be42c4c433
commit
52afeefb9d
2 changed files with 14 additions and 4 deletions
|
@ -1908,7 +1908,8 @@ static int prepend_name(char **buffer, int *buflen, struct qstr *name)
|
|||
* Convert a dentry into an ASCII path name. If the entry has been deleted
|
||||
* the string " (deleted)" is appended. Note that this is ambiguous.
|
||||
*
|
||||
* Returns the buffer or an error code if the path was too long.
|
||||
* Returns a pointer into the buffer or an error code if the
|
||||
* path was too long.
|
||||
*
|
||||
* "buflen" should be positive. Caller holds the dcache_lock.
|
||||
*
|
||||
|
@ -1984,7 +1985,10 @@ Elong:
|
|||
* Convert a dentry into an ASCII path name. If the entry has been deleted
|
||||
* the string " (deleted)" is appended. Note that this is ambiguous.
|
||||
*
|
||||
* Returns the buffer or an error code if the path was too long.
|
||||
* Returns a pointer into the buffer or an error code if the path was
|
||||
* too long. Note: Callers should use the returned pointer, not the passed
|
||||
* in buffer, to use the name! The implementation often starts at an offset
|
||||
* into the buffer, and may leave 0 bytes at the start.
|
||||
*
|
||||
* "buflen" should be positive.
|
||||
*/
|
||||
|
|
|
@ -389,8 +389,14 @@ char *mangle_path(char *s, char *p, char *esc)
|
|||
}
|
||||
EXPORT_SYMBOL(mangle_path);
|
||||
|
||||
/*
|
||||
* return the absolute path of 'dentry' residing in mount 'mnt'.
|
||||
/**
|
||||
* seq_path - seq_file interface to print a pathname
|
||||
* @m: the seq_file handle
|
||||
* @path: the struct path to print
|
||||
* @esc: set of characters to escape in the output
|
||||
*
|
||||
* return the absolute path of 'path', as represented by the
|
||||
* dentry / mnt pair in the path parameter.
|
||||
*/
|
||||
int seq_path(struct seq_file *m, struct path *path, char *esc)
|
||||
{
|
||||
|
|
Loading…
Reference in a new issue